Add support for CertDecodeFlags to DecodeChipCert #30013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #30013: Size comparison from 6e86760 to 43144fe Increases (5 builds for cc32xx, mbed, qpg)
Decreases (2 builds for cc32xx)
Full report (5 builds for cc32xx, mbed, qpg)
|
ksperling-apple
force-pushed
the
decode-cert-with-flags
branch
from
f448952 to
dd93fc7
Compare
|
PR #30013: Size comparison from 6e86760 to dd93fc7 Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl702, bl702l, cc32xx, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 26, 2023
This moves support for generating the TBSHash during decoding from ChipCertificateSet::LoadCert to DecodeChipCert. LoadCert can now delegate to DecodeChipCert and only contains a few extra checks to retain existing behavior.
…writer The original LoadCert avoided this work by calling DecodeECDSASignature directly, so this brings the refactored version back to baseline.
ksperling-apple
force-pushed
the
decode-cert-with-flags
branch
from
dd93fc7 to
3045336
Compare
|
PR #30013: Size comparison from 28de696 to 3045336 Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl702, bl702l, cc32xx, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 27, 2023
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
* Add support for CertDecodeFlags to DecodeChipCert This moves support for generating the TBSHash during decoding from ChipCertificateSet::LoadCert to DecodeChipCert. LoadCert can now delegate to DecodeChipCert and only contains a few extra checks to retain existing behavior. * Add ASN1Writer.IsNullWriter() and use it internally * Avoid conversion work in DecodeConvertECDSASignature if using a null writer The original LoadCert avoided this work by calling DecodeECDSASignature directly, so this brings the refactored version back to baseline. * Add test for DecodeChipCert with different options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves support for generating the TBSHash during decoding from ChipCertificateSet::LoadCert to DecodeChipCert. LoadCert can now delegate to DecodeChipCert and only contains a few extra checks to retain existing behavior.