-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move VerifySignature out of ChipCertificateSet as VerifyCertSignature() #30012
Merged
mergify
merged 1 commit into
project-chip:master
from
ksperling-apple:verify-cert-signature
Oct 26, 2023
Merged
Move VerifySignature out of ChipCertificateSet as VerifyCertSignature() #30012
mergify
merged 1 commit into
project-chip:master
from
ksperling-apple:verify-cert-signature
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It just operates on ChipCertificateData structs directly and is useful outside of ChipCertificateSet. Also move the check for kTBSHashPresent and the signature algorithm into the function.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
October 26, 2023 04:57
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 26, 2023 04:57
PR #30012: Size comparison from 6e86760 to f497cdd Increases (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, k32w, psoc6, telink)
Decreases (29 builds for bl702, bl702l, cc32xx, esp32, linux, mbed, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 26, 2023
tcarmelveilleux
approved these changes
Oct 26, 2023
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…() (project-chip#30012) It just operates on ChipCertificateData structs directly and is useful outside of ChipCertificateSet. Also move the check for kTBSHashPresent and the signature algorithm into the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just operates on ChipCertificateData structs directly and is useful outside of ChipCertificateSet.
Also move the check for kTBSHashPresent and the signature algorithm into the function.