-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve linker reenable ci v2 #28933
Merged
mergify
merged 9 commits into
project-chip:master
from
adabreuti:ResolveLinker_ReenableCI_v2
Aug 29, 2023
Merged
Resolve linker reenable ci v2 #28933
mergify
merged 9 commits into
project-chip:master
from
adabreuti:ResolveLinker_ReenableCI_v2
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esolveLinker_ReenableCI
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248 and
hicklin
August 28, 2023 21:45
pullapprove
bot
requested review from
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 28, 2023 21:45
PR #28933: Size comparison from 1e3c20a to a79ebab Decreases (1 build for efr32)
Full report (55 builds for cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 29, 2023
@andy31415 This PR should resolve the issue previously seen in which the smaller device builds were failing when merging to master. |
andy31415
approved these changes
Aug 29, 2023
PR #28933: Size comparison from ddacd49 to 5a5dc8c Increases (1 build for telink)
Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Update Example Applications with proper non-ota linker command files * Re-enable CI For TI platforms * Restyled by gn * Resolve CI Lighting app check * Disable Smaller Platform builds in CI --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR disables the smaller platform builds that were previously causing the failures.
This PR Re-enables CI for TI platforms, fixes #26957
It also resolves linker command issues/sizing issues which caused the CI to be disabled.
Validated all CC13x2x7 and CC13x4 platforms build OOB.