-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Add mrpRetryActiveThreshold response key for Disco… #28781
Merged
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_mrpRetryActiveThreshold
Aug 21, 2023
Merged
[matter_yamltests] Add mrpRetryActiveThreshold response key for Disco… #28781
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_mrpRetryActiveThreshold
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #28781: Size comparison from 5e15a87 to 5f76beb Increases (2 builds for bl602, bl702)
Decreases (1 build for k32w)
Full report (15 builds for bl602, bl702, bl702l, cc32xx, k32w, mbed, nrfconnect, qpg)
|
vivien-apple
force-pushed
the
MatterYamlTests_mrpRetryActiveThreshold
branch
from
August 21, 2023 14:16
5f76beb
to
76e7f8b
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
August 21, 2023 14:17
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
woody-apple,
younghak-hwang and
yufengwangca
August 21, 2023 14:17
PR #28781: Size comparison from fbc20e5 to 76e7f8b Increases (14 builds for k32w, linux, psoc6, telink)
Decreases (5 builds for bl602, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
yufengwangca
approved these changes
Aug 21, 2023
rquidute
approved these changes
Aug 21, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…very Commands
Problem
mrpRetryActiveThreshold
has been added toCommonResolutionData
by 47bd885 but it has not been added to YAML.