-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Json/Tlv]Add convertTlvTag function #28760
Merged
yunhanw-google
merged 5 commits into
project-chip:master
from
yunhanw-google:feature/ConvertTlvTag
Aug 19, 2023
Merged
[Json/Tlv]Add convertTlvTag function #28760
yunhanw-google
merged 5 commits into
project-chip:master
from
yunhanw-google:feature/ConvertTlvTag
Aug 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
August 18, 2023 18:41
PR #28760: Size comparison from a167c71 to a97c0a5 Increases (4 builds for bl602, cc32xx, psoc6)
Decreases (1 build for bl702)
Full report (22 builds for bl602, bl702, bl702l, cc32xx, cyw30739, linux, mbed, nrfconnect, psoc6, qpg)
|
yunhanw-google
force-pushed
the
feature/ConvertTlvTag
branch
from
August 18, 2023 19:42
a97c0a5
to
7ce2271
Compare
PR #28760: Size comparison from 850de9b to 7ce2271 Increases (2 builds for bl602, nrfconnect)
Decreases (1 build for bl702l)
Full report (15 builds for bl602, bl702, bl702l, cc32xx, k32w, mbed, nrfconnect, qpg)
|
yunhanw-google
force-pushed
the
feature/ConvertTlvTag
branch
from
August 18, 2023 20:43
7ce2271
to
c9ad39b
Compare
PR #28760: Size comparison from f4ec7c5 to c9ad39b Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #28760: Size comparison from f4ec7c5 to 1b2ef17 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
yunhanw-google
force-pushed
the
feature/ConvertTlvTag
branch
from
August 18, 2023 21:18
1b2ef17
to
d907e86
Compare
PR #28760: Size comparison from f4ec7c5 to d907e86 Increases (3 builds for bl702, nrfconnect)
Decreases (1 build for cc32xx)
Full report (17 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
yufengwangca
approved these changes
Aug 18, 2023
Co-authored-by: Yufeng Wang <[email protected]>
PR #28760: Size comparison from f4ec7c5 to 8813d79 Increases (1 build for nrfconnect)
Decreases (3 builds for cc32xx, k32w, nrfconnect)
Full report (10 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
|
saurabhst
reviewed
Aug 18, 2023
saurabhst
reviewed
Aug 18, 2023
Co-authored-by: saurabhst <[email protected]>
saurabhst
approved these changes
Aug 18, 2023
PR #28760: Size comparison from f4ec7c5 to 3cda21c Increases (8 builds for bl702, cyw30739, nrfconnect, psoc6, telink)
Decreases (7 builds for bl702, cc32xx, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Add convertTlvTag function * Restyled by clang-format * Update src/lib/support/jsontlv/JsonToTlv.h Co-authored-by: Yufeng Wang <[email protected]> --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Yufeng Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add convertTlvTag function for android controller use later.
The existing test cover it.