Set LastKnownGoodTime using UTC via python-generated header #28668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #28668: Size comparison from 9a35c44 to d51e419 Increases (5 builds for cc32xx, psoc6)
Decreases (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
Tested the patch on nrf platform and it works correctly. With timezone CET and local time 10:04:19 |
cecille
changed the title
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
cecille
changed the title
|
PR #28668: Size comparison from a167c71 to a1f3f41 Increases (5 builds for cc32xx, psoc6)
Decreases (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Aug 21, 2023
andy31415
reviewed
Aug 21, 2023
andy31415
approved these changes
Aug 21, 2023
|
PR #28668: Size comparison from a167c71 to 2ef77ec Increases above 0.2%:
Increases (22 builds for bl702, bl702l, cc32xx, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (51 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #28668: Size comparison from 270d8e2 to 48d9f9a Increases (5 builds for cc32xx, psoc6)
Decreases (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Aug 22, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
…chip#28668) * WIP: set LKGT using UTC via python * appease the linter * Changes from review * Remove header guard cruft
No. This will be generated once and not updated later. It does not work properly and I think it should be reverted. We can [have a way to] set the timestamp in the GN args via --args="chip_build_timestamp=XYZ". The build should not depend on the time since that's not hermetic. It's especially broken/confusing when caching is deployed. |
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…chip#28668) * WIP: set LKGT using UTC via python * appease the linter * Changes from review * Remove header guard cruft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LKGT fallback uses the c++ TIME macro, which uses local time, not UTC. There is no good UTC macro and the result is the LKGT can be ahead of the actual time for time zones that are ahead of utc.
This approach generates a header with the LKGT in the native chip epoch-s and uses it to set the LKGT.
Open questions:
Fixes: [BUG] Setting correct UTC time is rejected #28629