-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding invalid in state to status code file #28530
Merged
mergify
merged 4 commits into
project-chip:master
from
abeck-whirlpool:AddingInvalidInStateStatusCode
Aug 9, 2023
Merged
Adding invalid in state to status code file #28530
mergify
merged 4 commits into
project-chip:master
from
abeck-whirlpool:AddingInvalidInStateStatusCode
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
August 4, 2023 18:39
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
August 4, 2023 18:39
cecille
approved these changes
Aug 4, 2023
PR #28530: Size comparison from 1465733 to bba935b Increases (29 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, psoc6, telink)
Decreases (15 builds for bl702l, cc32xx, cyw30739, efr32, esp32, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 4, 2023
PR #28530: Size comparison from fe75cd1 to fc83797 Increases (30 builds for bl702, bl702l, cc32xx, linux, nrfconnect, psoc6, telink)
Decreases (10 builds for bl602, bl702, bl702l, efr32, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
* Adding invalid in state to status code file * Adding invalid in state to ember --------- Co-authored-by: abeck-riis <[email protected]>
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
* Adding invalid in state to status code file * Adding invalid in state to ember --------- Co-authored-by: abeck-riis <[email protected]>
This was referenced Sep 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quickfix to add INVALID_IN_STATE to StatusCodeLIst.h file as it is utilized by clusters for status recognition