-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python testing: Support QR / manual codes for commissioning #28479
Merged
mergify
merged 2 commits into
project-chip:master
from
cecille:matter_testing_support_setup_codes
Aug 8, 2023
Merged
python testing: Support QR / manual codes for commissioning #28479
mergify
merged 2 commits into
project-chip:master
from
cecille:matter_testing_support_setup_codes
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
August 2, 2023 19:39
pullapprove
bot
requested review from
mrjerryjohns,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple and
younghak-hwang
August 2, 2023 19:39
cecille
changed the title
Support QR / manual codes for commissioning
python testing: Support QR / manual codes for commissioning
Aug 2, 2023
PR #28479: Size comparison from 7f0e566 to 750aeb1 Increases (6 builds for bl602, nrfconnect, psoc6)
Decreases (5 builds for bl702, bl702l, psoc6)
Full report (25 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #28479: Size comparison from 7f0e566 to 79b910c Increases (12 builds for bl602, bl702, cc32xx, linux, nrfconnect, psoc6, telink)
Decreases (11 builds for bl702, bl702l, cyw30739, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Aug 8, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
…chip#28479) * Support QR / manual codes for commissioning * Remove now unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us run the tests with a qr or manual code instead of discriminator and passcode. This is more convenient if we want to run these tests against real-world products.