-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]add refrigerator example #28390
Merged
mergify
merged 22 commits into
project-chip:master
from
mideayanghui:feature/add-refrigerator-example
Aug 31, 2023
Merged
[Feature]add refrigerator example #28390
mergify
merged 22 commits into
project-chip:master
from
mideayanghui:feature/add-refrigerator-example
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
examples
scripts
labels
Jul 29, 2023
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
July 29, 2023 03:21
PR #28390: Size comparison from 2a681e3 to 8faf33a Increases (20 builds for bl602, bl702, bl702l, cc32xx, esp32, k32w, psoc6, telink)
Decreases (10 builds for cyw30739, efr32, esp32, nrfconnect, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Aug 1, 2023
examples/refrigerator-app/refrigerator-common/refrigerator-app.matter
Outdated
Show resolved
Hide resolved
examples/refrigerator-app/refrigerator-common/src/static-supported-temperature-levels.cpp
Outdated
Show resolved
Hide resolved
examples/refrigerator-app/refrigerator-common/src/static-supported-temperature-levels.cpp
Outdated
Show resolved
Hide resolved
PR #28390: Size comparison from 59a0b2f to e6c0643 Increases (8 builds for bl702l, cc32xx, psoc6, telink)
Decreases (7 builds for bl602, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
examples/refrigerator-app/refrigerator-common/refrigerator-app.matter
Outdated
Show resolved
Hide resolved
examples/refrigerator-app/refrigerator-common/refrigerator-app.matter
Outdated
Show resolved
Hide resolved
1. remove Refrigerator And Temperature Controlled Cabinet Mode cluster 2. remove Refrigerator alarm cluster 3. remove Binding and Group cluster in endpoint 1
PR #28390: Size comparison from af74ecf to 72cf88c Increases (6 builds for bl602, bl702l, telink)
Decreases (15 builds for cc32xx, cyw30739, efr32, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 28, 2023
examples/refrigerator-app/refrigerator-common/refrigerator-app.matter
Outdated
Show resolved
Hide resolved
examples/refrigerator-app/refrigerator-common/refrigerator-app.matter
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Aug 30, 2023
PR #28390: Size comparison from 2dc43d7 to ad948ce Decreases (2 builds for efr32, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28390: Size comparison from 35bce82 to dbdc003 Increases (1 build for telink)
Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Sep 12, 2023
* Add refrigerator example build script * Add refrigerator app * Restyled by whitespace * Restyled by gn * Restyled by prettier-markdown * fix document missing * Restyled by prettier-markdown * fix document build error * update zap and matter with project-chip#28299 * optimize code and add composition type for endpoint * Restyled by clang-format * Optimize endpoint 1: 1. remove Refrigerator And Temperature Controlled Cabinet Mode cluster 2. remove Refrigerator alarm cluster 3. remove Binding and Group cluster in endpoint 1 * Restyled by clang-format * fix build error * fix bug: test fail in TC-SM-1.1/TC-DT-1.1 * remove identify and groups cluster in root node * add tag list feauture in endpoint 2 and endpoint 3 * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Add refrigerator example build script * Add refrigerator app * Restyled by whitespace * Restyled by gn * Restyled by prettier-markdown * fix document missing * Restyled by prettier-markdown * fix document build error * update zap and matter with project-chip#28299 * optimize code and add composition type for endpoint * Restyled by clang-format * Optimize endpoint 1: 1. remove Refrigerator And Temperature Controlled Cabinet Mode cluster 2. remove Refrigerator alarm cluster 3. remove Binding and Group cluster in endpoint 1 * Restyled by clang-format * fix build error * fix bug: test fail in TC-SM-1.1/TC-DT-1.1 * remove identify and groups cluster in root node * add tag list feauture in endpoint 2 and endpoint 3 * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Matter 1.2 clusters missing refrigerator app example.
What's more, The refrigerator is a Endpoint Composition. The zap for this example is same as the picture shows.
Solution: