-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Thread]Fix thread network scan list encode when no network was found #27896
Merged
mergify
merged 1 commit into
project-chip:master
from
jmartinez-silabs:fix/threadScan_empty
Jul 11, 2023
Merged
[Thread]Fix thread network scan list encode when no network was found #27896
mergify
merged 1 commit into
project-chip:master
from
jmartinez-silabs:fix/threadScan_empty
Jul 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #27896: Size comparison from 12b6383 to be2e71b Increases (47 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for bl602, bl702, bl702l, cyw30739)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when the scan thread network found no results.
A zero-sized malloc was done which caused a malloc fail assert (at least on Silabs malloc implementation)
Even if the malloc failure didn't cause an assert, the following code would try to access the un-allocated
scanResponseArray
.Fix:
No operation is done on the encodable list or scans results if the network count is 0