-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Xcode project setting Text-Based InstallAPI Verification Mode #27418
Closed
krypton36
wants to merge
1
commit into
project-chip:master
from
krypton36:UpdateTextBaseInstallAPIVerificationMode
Closed
Update Xcode project setting Text-Based InstallAPI Verification Mode #27418
krypton36
wants to merge
1
commit into
project-chip:master
from
krypton36:UpdateTextBaseInstallAPIVerificationMode
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krypton36
commented
Jun 22, 2023
- Update Xcode settings TAPI_VERIFY_MODE to Errors Only.
- Xcode setting reference
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
June 22, 2023 19:19
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
June 22, 2023 19:19
krypton36
force-pushed
the
UpdateTextBaseInstallAPIVerificationMode
branch
from
June 22, 2023 19:20
e8f3348
to
a36d564
Compare
PR #27418: Size comparison from 6b34908 to a36d564 Increases (2 builds for bl602, bl702)
Decreases (2 builds for cc32xx, nrfconnect)
Full report (16 builds for bl602, bl702, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
krypton36
force-pushed
the
UpdateTextBaseInstallAPIVerificationMode
branch
from
June 22, 2023 19:59
a36d564
to
240cb26
Compare
PR #27418: Size comparison from 6b34908 to 240cb26 Increases (3 builds for esp32, telink)
Decreases (11 builds for bl602, bl702, cc32xx, esp32, nrfconnect, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jun 22, 2023
Closing PR. @bzbarsky-apple is going to properly fix the linking. |
This was fixed in #27424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.