-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing iMX Build #27402
Fixing iMX Build #27402
Conversation
PR #27402: Size comparison from 9cf7d36 to 94f55c2 Increases (6 builds for cc32xx, esp32, psoc6, qpg, telink)
Decreases (3 builds for qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27402: Size comparison from 509a55c to c432400 Increases (4 builds for esp32, psoc6, telink)
Decreases (13 builds for bl602, bl702, cc32xx, esp32, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@@ -1 +1 @@ | |||
0.7.18 Version bump reason: vscode ZEPHYR SDK env path update | |||
0.7.19.1 Version bump reason: Reducing size of imx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just 0.7.19 or 0.7.20?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To not conflict with another going on from Andrei
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the future I would vote for 3 digit only, to make our regex history easier. Conflicts are ok and intended.
PR #27402: Size comparison from 509a55c to 3248e64 Increases (6 builds for esp32, telink)
Decreases (15 builds for bl602, bl702, cc32xx, esp32, nrfconnect, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@@ -1 +1 @@ | |||
0.7.18 Version bump reason: vscode ZEPHYR SDK env path update | |||
0.7.19.1 Version bump reason: Reducing size of imx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 0.7.20?
Trying to reduce the size of iMX
Fixes #27400