ICD manager Implemenation #27283
Merged
ICD manager Implemenation #27283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app
examples
linux
nrf connect
platform
scripts
system
telink
labels
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs and
jmeg-sfy
…timer. Implemented ICDModes and initial operationalState logic WIP
… param. Call is handled by ICD Manager. Replace the sed ifdef by icd for silabs platform WIP
change #ifdef to #if fix missing rename. add // nogncheck on some conditional include Fix some error caught by the ci
…i. Priority to the thread imp for now. Needs to be reworked
…to PublicEventTypes for the time being
jmartinez-silabs
force-pushed
the
ICD_Manager
branch
from
fc1976b to
876e9ff
Compare
|
PR #27283: Size comparison from 693d5ee to 876e9ff Increases (36 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (21 builds for k32w, linux, nrfconnect, qpg, telink)
Full report (69 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
hicklin,
mhazley,
p0fi,
plauric,
tima-q and
tobiasgraf
bzbarsky-apple
approved these changes
Jul 10, 2023
|
Issues that require a follow-up to this PR #27864 |
woody-apple
pushed a commit
to woody-apple/connectedhomeip
that referenced
this pull request
Jul 12, 2023
* Add Events for ICD (WIP) * Rename SED defines, Add some timer funcionality to Extend a existing timer. Implemented ICDModes and initial operationalState logic WIP * Change SetFastPolling and SetSlowPolling to setPollingInterval with a param. Call is handled by ICD Manager. Replace the sed ifdef by icd for silabs platform WIP * Fix a bunch of dependencies, includes and build issues WIP * Use a init function instead of the constructor, as the attributes value aren't ready * Add a Keep active mechanism for commisisoning window and failsafe * cleanup, add app user wakeup change #ifdef to #if fix missing rename. add // nogncheck on some conditional include Fix some error caught by the ci * Addresses comments + conditional define for tests * SetPollingInterval causes issue for apps that has both thread and wifi. Priority to the thread imp for now. Needs to be reworked * Rebase, It brings updated system Apis, And addresse most of the comments * Stay active when an exchange context expect a response. * Update The message rx handling event naming. Move related ICD events to PublicEventTypes for the time being * #if ICD_SERVER the icd related event posts * Address comments and nits
doru91
added a commit
to NXP/matter
that referenced
this pull request
Aug 4, 2023
Add platform configurations required to use the ICD Manager Implementation (introduced by upstream PR project-chip#27283). Signed-off-by: Doru Gucea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the ICD manager using a timer-based and eventing mechanism. It uses the ICD cluster variables to determine the periods in which the ICD manager needs to be in Active or Idle mode.
Additionally, the Commissioning window and failsafe status can keep the ICD in Active Mode for a longer period than the standard Active mode interval specified in the ICD attributes.
Notes:
CHIP_CONFIG_ENABLE_ICD_SERVERand does not impact any app not built as an ICD.