Optimize compilation time #27228
Merged
Optimize compilation time #27228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
Damian-Nordic
force-pushed
the
compilation-time
branch
from
4a40187 to
68636f6
Compare
1. Do not to include cluster-objects.h if not needed as parsing such a large header significantly impacts the build time and in most cases it is enough to include ClusterEnums.h. 2. Do not build the controller library for embedded targets, by default. If needed, this can be overriden using the chip_build_controller argument from lib.gni.
Damian-Nordic
force-pushed
the
compilation-time
branch
from
68636f6 to
ccb8d2c
Compare
|
PR #27228: Size comparison from ecd0f6f to ccb8d2c Increases (15 builds for bl702, cc32xx, cyw30739, esp32, mbed, psoc6, qpg, telink)
Decreases (25 builds for bl602, bl702, cc32xx, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Full report (39 builds for bl602, bl702, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 14, 2023
Damian-Nordic
force-pushed
the
compilation-time
branch
from
ed02d2a to
88c1059
Compare
|
PR #27228: Size comparison from 2eef730 to 88c1059 Increases (3 builds for cc32xx, mbed, qpg)
Decreases (3 builds for cc32xx, nrfconnect, qpg)
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
|
Damian-Nordic
force-pushed
the
compilation-time
branch
from
88c1059 to
419ecd1
Compare
|
PR #27228: Size comparison from 2eef730 to 419ecd1 Increases (19 builds for bl702, cc32xx, cyw30739, k32w, linux, mbed, psoc6, qpg, telink)
Decreases (35 builds for bl602, bl702, cc32xx, cyw30739, esp32, k32w, linux, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jun 15, 2023
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
* Optimize compilation time 1. Do not to include cluster-objects.h if not needed as parsing such a large header significantly impacts the build time and in most cases it is enough to include ClusterEnums.h. 2. Do not build the controller library for embedded targets, by default. If needed, this can be overriden using the chip_build_controller argument from lib.gni. * Fix build
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
This reverts commit e32371d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster-objects.hif not needed as parsing such a large header significantly impacts the build time and in most cases it is enough to includeClusterEnums.h.It reduces the time of building
libCHIP.aon my PC from almost 1 min 40s to about 1 minute for nRF Connect platform.Overall, I think we would greatly speed up the compilation time if
cluster-objects.*files were divided into one file per cluster or at least into utility and application clusters.