Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format the node id as hex in MTRDevice description. #27118

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Format the node id as hex in MTRDevice description. #27118

merged 1 commit into from
Jun 7, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the darwin label Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023 •
edited
Loading

PR #27118: Size comparison from 2520f47 to fd69da3

Increases (8 builds for bl602, cc32xx, telink)
platform target config section 2520f47 fd69da3 change % change
bl602 lighting-app bl602 (read/write) 1367394 1367402 8 0.0
.text 1047384 1047388 4 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 23080418 23080420 2 0.0
telink all-clusters-app tlsr9518adk80d text 707454 707456 2 0.0
bridge-app tlsr9518adk80d (read/write) 928768 928776 8 0.0
text 641872 641874 2 0.0
contact-sensor-app tlsr9518adk80d text 585006 585008 2 0.0
light-switch-app tlsr9518adk80d text 599634 599636 2 0.0
lock-app tlsr9518adk80d text 613634 613636 2 0.0
pump-controller-app tlsr9518adk80d text 581110 581112 2 0.0
Decreases (8 builds for bl702, psoc6, qpg, telink)
platform target config section 2520f47 fd69da3 change % change
bl702 lighting-app bl702 .debug_info 44996310 44996309 -1 -0.0
.text 978058 978056 -2 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 26042169 26042168 -1 -0.0
qpg lighting-app qpg6105+debug (read/write) 1170452 1170444 -8 -0.0
.text 617548 617540 -8 -0.0
lock-app qpg6105+debug (read/write) 1139860 1139852 -8 -0.0
.text 586960 586952 -8 -0.0
telink all-clusters-minimal-app tlsr9518adk80d text 664822 664820 -2 -0.0
pump-app tlsr9518adk80d text 590728 590726 -2 -0.0
thermostat tlsr9518adk80d text 615990 615988 -2 -0.0
window-covering tlsr9518adk80d text 610914 610912 -2 -0.0
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
platform target config section 2520f47 fd69da3 change % change
bl602 lighting-app bl602 (read/write) 1367394 1367402 8 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1047384 1047388 4 0.0
bl602+rpc (read/write) 1414646 1414646 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1079266 1079266 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1199599 1199599 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1552228 1552228 0 0.0
.debug_aranges 149448 149448 0 0.0
.debug_frame 550192 550192 0 0.0
.debug_info 44996310 44996309 -1 -0.0
.debug_line 5604019 5604019 0 0.0
.debug_loc 3831181 3831181 0 0.0
.debug_ranges 397952 397952 0 0.0
.debug_str 4345020 4345020 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107264 107264 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582046 582046 0 0.0
.symtab 175456 175456 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
978058 978056 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1289123 1289123 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1711296 1711296 0 0.0
.debug_aranges 157736 157736 0 0.0
.debug_frame 578204 578204 0 0.0
.debug_info 49943971 49943971 0 0.0
.debug_line 6020061 6020061 0 0.0
.debug_loc 4034256 4034256 0 0.0
.debug_ranges 423432 423432 0 0.0
.debug_str 4770496 4770496 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121792 121792 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 643549 643549 0 0.0
.symtab 194016 194016 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1051714 1051714 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 606178 606178 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 952074 952074 0 0.0
.debug_aranges 118832 118832 0 0.0
.debug_frame 405884 405884 0 0.0
.debug_info 23080418 23080420 2 0.0
.debug_line 2879491 2879491 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1724970 1724970 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107457 107457 0 0.0
.debug_str 3785722 3785722 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104546 104546 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484563 484563 0 0.0
.symtab 287712 287712 0 0.0
.text 499512 499512 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 542235 542235 0 0.0
.app_xip_area 434861 434861 0 0.0
.bss 62352 62352 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 529267 529267 0 0.0
.app_xip_area 416757 416757 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566659 566659 0 0.0
.app_xip_area 460213 460213 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 531043 531043 0 0.0
.app_xip_area 422029 422029 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 986252 986252 0 0.0
.bss 179856 179856 0 0.0
.data 2144 2144 0 0.0
.text 804232 804232 0 0.0
BRD4187C (read/write) 1019752 1019752 0 0.0
.bss 159588 159588 0 0.0
.data 2788 2788 0 0.0
.text 857356 857356 0 0.0
lock-app BRD4161A+wf200 (read/write) 1069128 1069128 0 0.0
.bss 174160 174160 0 0.0
.data 2152 2152 0 0.0
.text 892796 892796 0 0.0
window-app BRD4187C (read/write) 1088792 1088792 0 0.0
.bss 142572 142572 0 0.0
.data 2680 2680 0 0.0
.text 943520 943520 0 0.0
esp32 all-clusters-app c3devkit (read only) 1076108 1076108 0 0.0
(read/write) 1584968 1584968 0 0.0
.dram0.bss 75744 75744 0 0.0
.dram0.data 13964 13964 0 0.0
.flash.rodata 216128 216128 0 0.0
.flash.text 1076108 1076108 0 0.0
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1122631 1122631 0 0.0
(read/write) 494230 494230 0 0.0
.dram0.bss 80752 80752 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 244024 244024 0 0.0
.flash.text 1117247 1117247 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 584764 584764 0 0.0
(read/write) 90108 90108 0 0.0
.bss 66104 66104 0 0.0
.data 2168 2168 0 0.0
.text 584228 584228 0 0.0
light k32w0+release (read only) 583452 583452 0 0.0
(read/write) 89756 89756 0 0.0
.bss 65768 65768 0 0.0
.data 2156 2156 0 0.0
.text 582916 582916 0 0.0
lock k32w0+release (read only) 556060 556060 0 0.0
(read/write) 87556 87556 0 0.0
.bss 63632 63632 0 0.0
.data 2100 2100 0 0.0
.text 555524 555524 0 0.0
linux all-clusters-app debug (read only) 3263717 3263717 0 0.0
(read/write) 158104 158104 0 0.0
.bss 59392 59392 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 90040 90040 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 231496 231496 0 0.0
.text 2841301 2841301 0 0.0
all-clusters-minimal-app debug (read only) 3042149 3042149 0 0.0
(read/write) 145832 145832 0 0.0
.bss 57920 57920 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 79400 79400 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 224008 224008 0 0.0
.text 2632245 2632245 0 0.0
bridge-app debug (read only) 2521341 2521341 0 0.0
(read/write) 129768 129768 0 0.0
.bss 50232 50232 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 172680 172680 0 0.0
.text 2175909 2175909 0 0.0
chip-tool debug (read only) 15593481 15593481 0 0.0
(read/write) 710112 710112 0 0.0
.bss 26424 26424 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 673840 673840 0 0.0
.dynamic 608 608 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 687765 687765 0 0.0
.text 13257828 13257828 0 0.0
chip-tool-ipv6only arm64 (read only) 14908788 14908788 0 0.0
(read/write) 763176 763176 0 0.0
.bss 34408 34408 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 703760 703760 0 0.0
.dynamic 560 560 0 0.0
.got 16752 16752 0 0.0
.init 24 24 0 0.0
.init_array 224 224 0 0.0
.rodata 623848 623848 0 0.0
.text 12479572 12479572 0 0.0
lighting-app debug+rpc+ui (read only) 3385841 3385841 0 0.0
(read/write) 136400 136400 0 0.0
.bss 49760 49760 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 77056 77056 0 0.0
.dynamic 656 656 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 286196 286196 0 0.0
.text 2902162 2902162 0 0.0
lock-app debug (read only) 2613973 2613973 0 0.0
(read/write) 117200 117200 0 0.0
.bss 45344 45344 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 63896 63896 0 0.0
.dynamic 608 608 0 0.0
.got 4592 4592 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 200104 200104 0 0.0
.text 2249285 2249285 0 0.0
ota-provider-app debug (read only) 2211085 2211085 0 0.0
(read/write) 103792 103792 0 0.0
.bss 44528 44528 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 52056 52056 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 153800 153800 0 0.0
.text 1915333 1915333 0 0.0
ota-requestor-app debug (read only) 2379605 2379605 0 0.0
(read/write) 111552 111552 0 0.0
.bss 46960 46960 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 56912 56912 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 157896 157896 0 0.0
.text 2070885 2070885 0 0.0
shell debug (read only) 2797409 2797409 0 0.0
(read/write) 146488 146488 0 0.0
.bss 58312 58312 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 81096 81096 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 199634 199634 0 0.0
.text 2430882 2430882 0 0.0
thermostat-no-ble arm64 (read only) 2607084 2607084 0 0.0
(read/write) 143032 143032 0 0.0
.bss 52344 52344 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79336 79336 0 0.0
.dynamic 560 560 0 0.0
.got 5512 5512 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 129608 129608 0 0.0
.text 2211700 2211700 0 0.0
tv-app debug (read only) 3316145 3316145 0 0.0
(read/write) 261632 261632 0 0.0
.bss 171232 171232 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79584 79584 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 222136 222136 0 0.0
.text 2897394 2897394 0 0.0
tv-casting-app debug (read only) 9135265 9135265 0 0.0
(read/write) 219976 219976 0 0.0
.bss 52064 52064 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 159616 159616 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 992 992 0 0.0
.rodata 329676 329676 0 0.0
.text 8375362 8375362 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2497920 2497920 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1460604 1460604 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841992 841992 0 0.0
(read/write) 1727972 1727972 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188788 188788 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1297177 1297177 0 0.0
.debug_aranges 148544 148544 0 0.0
.debug_frame 497376 497376 0 0.0
.debug_info 32227363 32227363 0 0.0
.debug_line 4032553 4032553 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2298966 2298966 0 0.0
.debug_rnglists 143906 143906 0 0.0
.debug_str 4349193 4349193 0 0.0
.heap 841992 841992 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 750867 750867 0 0.0
.symtab 478784 478784 0 0.0
.text 0 0 0 0.0
1528236 1528236 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 843328 843328 0 0.0
(read/write) 1660620 1660620 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187452 187452 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1284935 1284935 0 0.0
.debug_aranges 147296 147296 0 0.0
.debug_frame 498320 498320 0 0.0
.debug_info 3169044 3169044 0 0.0
.debug_line 4038107 4038107 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2283797 2283797 0 0.0
.debug_rnglists 142352 142352 0 0.0
.debug_str 4332123 4332123 0 0.0
.heap 843328 843328 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 699748 699748 0 0.0
.symtab 459904 459904 0 0.0
.text 1462220 1462220 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849560 849560 0 0.0
(read/write) 1593148 1593148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181388 181388 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1122518 1122518 0 0.0
.debug_aranges 137632 137632 0 0.0
.debug_frame 462228 462228 0 0.0
.debug_info 26488271 26488271 0 0.0
.debug_line 3609101 3609101 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2124665 2124665 0 0.0
.debug_rnglists 132344 132344 0 0.0
.debug_str 4146197 4146197 0 0.0
.heap 849560 849560 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 623332 623332 0 0.0
.symtab 425328 425328 0 0.0
.text 1400980 1400980 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821960 821960 0 0.0
(read/write) 1626324 1626324 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208988 208988 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1104792 1104792 0 0.0
.debug_aranges 136024 136024 0 0.0
.debug_frame 456576 456576 0 0.0
.debug_info 26042169 26042168 -1 -0.0
.debug_line 3549202 3549202 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2098704 2098704 0 0.0
.debug_rnglists 130309 130309 0 0.0
.debug_str 4106756 4106756 0 0.0
.heap 821960 821960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 596464 596464 0 0.0
.symtab 416928 416928 0 0.0
.text 1406556 1406556 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1170452 1170444 -8 -0.0
.bss 99928 99928 0 0.0
.data 852 852 0 0.0
.text 617548 617540 -8 -0.0
lock-app qpg6105+debug (read/write) 1139860 1139852 -8 -0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586960 586952 -8 -0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1033768 1033768 0 0.0
bss 97648 97648 0 0.0
text 707454 707456 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 961020 961020 0 0.0
bss 96164 96164 0 0.0
text 664822 664820 -2 -0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 928768 928776 8 0.0
bss 100308 100308 0 0.0
text 641872 641874 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 860436 860436 0 0.0
bss 89968 89968 0 0.0
text 585006 585008 2 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876760 876760 0 0.0
bss 90136 90136 0 0.0
text 599634 599636 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 965008 965008 0 0.0
bss 98500 98500 0 0.0
text 678568 678568 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 976388 976388 0 0.0
bss 102748 102748 0 0.0
text 686090 686090 0 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1034108 1034108 0 0.0
bss 100064 100064 0 0.0
text 723252 723252 0 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1065864 1065864 0 0.0
bss 111140 111140 0 0.0
text 743608 743608 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 915508 915508 0 0.0
bss 90632 90632 0 0.0
text 613634 613636 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883036 883036 0 0.0
bss 91244 91244 0 0.0
text 606850 606850 0 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 865996 865996 0 0.0
bss 90100 90100 0 0.0
text 590728 590726 -2 -0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 853056 853056 0 0.0
bss 89900 89900 0 0.0
text 581110 581112 2 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 849212 849212 0 0.0
bss 89808 89808 0 0.0
text 576740 576740 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 894956 894956 0 0.0
bss 90344 90344 0 0.0
text 615990 615988 -2 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 890336 890336 0 0.0
bss 90636 90636 0 0.0
text 610914 610912 -2 -0.0

@github-actions
Copy link

github-actions bot commented Jun 7, 2023 •
edited
Loading

PR #27118: Size comparison from 42b424d to 8ce0c57

Increases (10 builds for bl602, bl702, nrfconnect, telink)
platform target config section 42b424d 8ce0c57 change % change
bl602 lighting-app bl602 .text 1047892 1047894 2 0.0
bl602+rpc .text 1079518 1079520 2 0.0
bl702 lighting-app bl702+rpc .debug_info 49944357 49944358 1 0.0
.text 1051974 1051976 2 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp (read/write) 1312788 1312804 16 0.0
text 751196 751200 4 0.0
telink all-clusters-minimal-app tlsr9518adk80d (read/write) 961040 961048 8 0.0
text 664832 664834 2 0.0
contact-sensor-app tlsr9518adk80d text 585002 585006 4 0.0
lighting-app-factory-data tlsr9518adk80d text 686210 686212 2 0.0
lock-app tlsr9518adk80d text 613630 613632 2 0.0
ota-requestor-app tlsr9518adk80d text 606846 606848 2 0.0
temperature-measurement-app tlsr9518adk80d text 576738 576740 2 0.0
Decreases (8 builds for cyw30739, esp32, mbed, psoc6, telink)
platform target config section 42b424d 8ce0c57 change % change
cyw30739 switch cyw930739m2evb_01 (read/write) 531035 531027 -8 -0.0
.app_xip_area 422021 422013 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1076328 1076326 -2 -0.0
.flash.text 1076328 1076326 -2 -0.0
m5stack (read/write) 494250 494246 -4 -0.0
.flash.rodata 244028 244024 -4 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2497920 2497856 -64 -0.0
.text 1460604 1460540 -64 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 32227759 32227758 -1 -0.0
telink all-clusters-app tlsr9518adk80d text 707578 707576 -2 -0.0
pump-app tlsr9518adk80d text 590724 590722 -2 -0.0
thermostat tlsr9518adk80d text 615988 615986 -2 -0.0
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 42b424d 8ce0c57 change % change
bl602 lighting-app bl602 (read/write) 1367922 1367922 0 0.0
.bss 87902 87902 0 0.0
.data 9648 9648 0 0.0
.text 1047892 1047894 2 0.0
bl602+rpc (read/write) 1414910 1414910 0 0.0
.bss 95950 95950 0 0.0
.data 10040 10040 0 0.0
.text 1079518 1079520 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1199871 1199871 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67601 67601 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1552228 1552228 0 0.0
.debug_aranges 149448 149448 0 0.0
.debug_frame 550160 550160 0 0.0
.debug_info 44996697 44996697 0 0.0
.debug_line 5605194 5605194 0 0.0
.debug_loc 3831547 3831547 0 0.0
.debug_ranges 398168 398168 0 0.0
.debug_str 4345080 4345080 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107264 107264 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582046 582046 0 0.0
.symtab 175456 175456 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
978320 978320 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1289395 1289395 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75649 75649 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1711296 1711296 0 0.0
.debug_aranges 157736 157736 0 0.0
.debug_frame 578172 578172 0 0.0
.debug_info 49944357 49944358 1 0.0
.debug_line 6021236 6021236 0 0.0
.debug_loc 4034622 4034622 0 0.0
.debug_ranges 423648 423648 0 0.0
.debug_str 4770556 4770556 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121792 121792 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 643549 643549 0 0.0
.symtab 194016 194016 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1051974 1051976 2 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 606178 606178 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 952074 952074 0 0.0
.debug_aranges 118832 118832 0 0.0
.debug_frame 405884 405884 0 0.0
.debug_info 23080418 23080418 0 0.0
.debug_line 2879487 2879487 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1724970 1724970 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107457 107457 0 0.0
.debug_str 3785722 3785722 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104546 104546 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484563 484563 0 0.0
.symtab 287712 287712 0 0.0
.text 499512 499512 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 542371 542371 0 0.0
.app_xip_area 434981 434981 0 0.0
.bss 62368 62368 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 529259 529259 0 0.0
.app_xip_area 416749 416749 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566651 566651 0 0.0
.app_xip_area 460205 460205 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 531035 531027 -8 -0.0
.app_xip_area 422021 422013 -8 -0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 986508 986508 0 0.0
.bss 179872 179872 0 0.0
.data 2144 2144 0 0.0
.text 804472 804472 0 0.0
BRD4187C (read/write) 1019896 1019896 0 0.0
.bss 159604 159604 0 0.0
.data 2788 2788 0 0.0
.text 857484 857484 0 0.0
lock-app BRD4161A+wf200 (read/write) 1069144 1069144 0 0.0
.bss 174160 174160 0 0.0
.data 2152 2152 0 0.0
.text 892812 892812 0 0.0
window-app BRD4187C (read/write) 1088800 1088800 0 0.0
.bss 142572 142572 0 0.0
.data 2680 2680 0 0.0
.text 943528 943528 0 0.0
esp32 all-clusters-app c3devkit (read only) 1076328 1076326 -2 -0.0
(read/write) 1584984 1584984 0 0.0
.dram0.bss 75760 75760 0 0.0
.dram0.data 13964 13964 0 0.0
.flash.rodata 216128 216128 0 0.0
.flash.text 1076328 1076326 -2 -0.0
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1122731 1122731 0 0.0
(read/write) 494250 494246 -4 -0.0
.dram0.bss 80768 80768 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 244028 244024 -4 -0.0
.flash.text 1117347 1117347 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 584748 584748 0 0.0
(read/write) 90108 90108 0 0.0
.bss 66104 66104 0 0.0
.data 2168 2168 0 0.0
.text 584212 584212 0 0.0
light k32w0+release (read only) 583452 583452 0 0.0
(read/write) 89756 89756 0 0.0
.bss 65768 65768 0 0.0
.data 2156 2156 0 0.0
.text 582916 582916 0 0.0
lock k32w0+release (read only) 556044 556044 0 0.0
(read/write) 87556 87556 0 0.0
.bss 63632 63632 0 0.0
.data 2100 2100 0 0.0
.text 555508 555508 0 0.0
linux chip-tool-ipv6only arm64 (read only) 14908788 14908788 0 0.0
(read/write) 763176 763176 0 0.0
.bss 34408 34408 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 703760 703760 0 0.0
.dynamic 560 560 0 0.0
.got 16752 16752 0 0.0
.init 24 24 0 0.0
.init_array 224 224 0 0.0
.rodata 623848 623848 0 0.0
.text 12479572 12479572 0 0.0
thermostat-no-ble arm64 (read only) 2607084 2607084 0 0.0
(read/write) 143032 143032 0 0.0
.bss 52344 52344 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79336 79336 0 0.0
.dynamic 560 560 0 0.0
.got 5512 5512 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 129608 129608 0 0.0
.text 2211700 2211700 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2497920 2497856 -64 -0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1460604 1460540 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1209936 1209936 0 0.0
bss 154745 154745 0 0.0
rodata 137380 137380 0 0.0
text 838752 838752 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1312788 1312804 16 0.0
bss 138075 138075 0 0.0
rodata 132816 132816 0 0.0
text 751196 751200 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1148292 1148292 0 0.0
bss 153377 153377 0 0.0
rodata 111096 111096 0 0.0
text 804748 804748 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841984 841984 0 0.0
(read/write) 1728204 1728204 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188796 188796 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1297175 1297175 0 0.0
.debug_aranges 148544 148544 0 0.0
.debug_frame 497372 497372 0 0.0
.debug_info 32227759 32227758 -1 -0.0
.debug_line 4033283 4033283 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2299246 2299246 0 0.0
.debug_rnglists 144026 144026 0 0.0
.debug_str 4349253 4349253 0 0.0
.heap 841984 841984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 750867 750867 0 0.0
.symtab 478784 478784 0 0.0
.text 0 0 0 0.0
1528460 1528460 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 843312 843312 0 0.0
(read/write) 1660668 1660668 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187468 187468 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1284933 1284933 0 0.0
.debug_aranges 147296 147296 0 0.0
.debug_frame 498316 498316 0 0.0
.debug_info 31690846 31690846 0 0.0
.debug_line 4038837 4038837 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2284077 2284077 0 0.0
.debug_rnglists 142472 142472 0 0.0
.debug_str 4332183 4332183 0 0.0
.heap 843312 843312 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 699748 699748 0 0.0
.symtab 459904 459904 0 0.0
.text 1462252 1462252 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849544 849544 0 0.0
(read/write) 1593404 1593404 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181404 181404 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1122518 1122518 0 0.0
.debug_aranges 137632 137632 0 0.0
.debug_frame 462224 462224 0 0.0
.debug_info 26488700 26488700 0 0.0
.debug_line 3609823 3609823 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2124945 2124945 0 0.0
.debug_rnglists 132464 132464 0 0.0
.debug_str 4146257 4146257 0 0.0
.heap 849544 849544 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 623332 623332 0 0.0
.symtab 425328 425328 0 0.0
.text 1401220 1401220 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821960 821960 0 0.0
(read/write) 1626308 1626308 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208988 208988 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1104790 1104790 0 0.0
.debug_aranges 136024 136024 0 0.0
.debug_frame 456576 456576 0 0.0
.debug_info 26042137 26042137 0 0.0
.debug_line 3549206 3549206 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2098704 2098704 0 0.0
.debug_rnglists 130309 130309 0 0.0
.debug_str 4106756 4106756 0 0.0
.heap 821960 821960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 596464 596464 0 0.0
.symtab 416928 416928 0 0.0
.text 1406540 1406540 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1170572 1170572 0 0.0
.bss 99944 99944 0 0.0
.data 852 852 0 0.0
.text 617668 617668 0 0.0
lock-app qpg6105+debug (read/write) 1139852 1139852 0 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586952 586952 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1033900 1033900 0 0.0
bss 97660 97660 0 0.0
text 707578 707576 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 961040 961048 8 0.0
bss 96176 96176 0 0.0
text 664832 664834 2 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 928768 928768 0 0.0
bss 100308 100308 0 0.0
text 641870 641870 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 860436 860436 0 0.0
bss 89968 89968 0 0.0
text 585002 585006 4 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876760 876760 0 0.0
bss 90136 90136 0 0.0
text 599630 599630 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 965148 965148 0 0.0
bss 98512 98512 0 0.0
text 678692 678692 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 976520 976520 0 0.0
bss 102760 102760 0 0.0
text 686210 686212 2 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1034240 1034240 0 0.0
bss 100076 100076 0 0.0
text 723376 723376 0 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1065996 1065996 0 0.0
bss 111152 111152 0 0.0
text 743732 743732 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 915508 915508 0 0.0
bss 90632 90632 0 0.0
text 613630 613632 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883036 883036 0 0.0
bss 91244 91244 0 0.0
text 606846 606848 2 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 865996 865996 0 0.0
bss 90100 90100 0 0.0
text 590724 590722 -2 -0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 853056 853056 0 0.0
bss 89900 89900 0 0.0
text 581108 581108 0 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 849212 849212 0 0.0
bss 89808 89808 0 0.0
text 576738 576740 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 894956 894956 0 0.0
bss 90344 90344 0 0.0
text 615988 615986 -2 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 890328 890328 0 0.0
bss 90636 90636 0 0.0
text 610908 610908 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 1c49e06 into project-chip:master Jun 7, 2023
@bzbarsky-apple bzbarsky-apple deleted the log-nodeid-hex branch June 7, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksperling-apple ksperling-apple ksperling-apple approved these changes

@vivien-apple vivien-apple vivien-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @tcarmelveilleux @vivien-apple @ksperling-apple