-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Bump nRF Connect SDK version in Docker #27004
[nrfconnect] Bump nRF Connect SDK version in Docker #27004
Conversation
PR #27004: Size comparison from 68621d0 to ffe2d25 Increases (5 builds for bl602, bl702, nrfconnect, qpg)
Decreases (1 build for bl602)
Full report (16 builds for bl602, bl702, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
ffe2d25
to
d13d0de
Compare
PR #27004: Size comparison from 68621d0 to d13d0de Increases (6 builds for bl702, nrfconnect, psoc6, qpg)
Decreases (4 builds for bl602, cyw30739, psoc6, qpg)
Full report (40 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
d13d0de
to
d1c9851
Compare
PR #27004: Size comparison from 1ae7c93 to d1c9851 Increases (5 builds for bl602, bl702, cc32xx, nrfconnect, psoc6)
Decreases (1 build for bl702)
Full report (24 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
Regular update of nRF Connect SDK to 2.4.0 version
d1c9851
to
240538f
Compare
PR #27004: Size comparison from 1ae7c93 to 240538f Increases (9 builds for bl602, bl702, cc32xx, nrfconnect, psoc6, telink)
Decreases (10 builds for bl702, cyw30739, k32w, nrfconnect, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@@ -161,7 +161,7 @@ def generate(self): | |||
zephyr_base = os.environ['ZEPHYR_BASE'] | |||
nrfconnect_sdk = os.path.dirname(zephyr_base) | |||
zephyr_sdk_dir = os.environ.get('ZEPHYR_SDK_INSTALL_DIR') or os.path.join( | |||
os.environ['NRF5_TOOLS_ROOT'], 'zephyr-sdk-0.15.2') | |||
os.environ['NRF5_TOOLS_ROOT'], 'zephyr-sdk-0.16.0') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in hindsight this was NOT safe: this makes things break for all builders that have not yet upgraded to the new dockerfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change reverted in #27015
Regular update of nRF Connect SDK to 2.4.0 version