Add concentration measuerment clusters to all clusters app #26883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rement-cluster-definition
… 26225-add-concentration-measurement-cluster-definition
Should match spec
Adding „Concentration“ to the cluster name. This naming convention maintains the integrity of the base cluster's name while also specifying the unique substance that the aliased version pertains to.
… 26225-add-concentration-measurement-cluster-definition # Conflicts: # src/controller/java/generated/java/chip/devicecontroller/ClusterReadMapping.java
…ement-cluster.xml Co-authored-by: Boris Zbarsky <[email protected]>
…rement-cluster-definition
…r-definition # Conflicts: # src/app/zap_cluster_list.json # src/controller/data_model/BUILD.gn # src/controller/data_model/controller-clusters.matter # zzz_generated/darwin/controller-clusters/zap-generated/endpoint_config.h
AVG_MEASURED_VALUE_WINDOW and PEAK_MEASURED_VALUE_WINDOW are using elapsed_s as per spec.
Lines were added twice due to poor merging 🙁
…r-definition # Conflicts: # src/controller/java/generated/java/chip/devicecontroller/ClusterReadMapping.java # zzz_generated/darwin/controller-clusters/zap-generated/CHIPClientCallbacks.h # zzz_generated/darwin/controller-clusters/zap-generated/CHIPClusters.h # zzz_generated/darwin/controller-clusters/zap-generated/endpoint_config.h # zzz_generated/darwin/controller-clusters/zap-generated/gen_config.h
Rename VOC_CONCENTRATION_MEASUREMENT_CLUSTER to TVOC_CONCENTRATION_MEASUREMENT_CLUSTER
…on concentration measurement clusters to the all-clusters-app.
github-actions
bot
added
app
controller
darwin
examples
github
scripts
workflows
labels
…s_to_all_clusters_app
|
Re-opened this here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 26833.
Adds the PM1, PM2.5, PM10, CO2, NO2, TVOC, CH2O, CO, Ozone & Radon concentration measurement clusters to the all-clusters-app.
This PR depends on this PR to be merged.