-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Thread Network Diagnostics XML to the spec. #26860
Merged
andy31415
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-thread-diagnostics
May 30, 2023
Merged
Align Thread Network Diagnostics XML to the spec. #26860
andy31415
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-thread-diagnostics
May 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
May 26, 2023 05:12
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
May 26, 2023 05:12
yufengwangca
approved these changes
May 26, 2023
PR #26860: Size comparison from 49e36af to 805e59c Increases (48 builds for bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (12 builds for bl602, bl702, cc32xx, efr32, esp32, linux, psoc6)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
May 27, 2023
bzbarsky-apple
force-pushed
the
rename-thread-diagnostics
branch
from
May 27, 2023 04:41
805e59c
to
4bb35b3
Compare
PR #26860: Size comparison from f223899 to 4bb35b3 Increases (45 builds for bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl602, bl702, cc32xx, efr32, esp32, linux, nrfconnect, psoc6)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec changes happened in
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6169 and
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6338
Fixes #25339