-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Add a menuconfig option to enable/disable route hook in matter #26830
Merged
chshu
merged 1 commit into
project-chip:master
from
wqx6:esp32/route_hook_menuconfig_option
Jun 1, 2023
Merged
ESP32: Add a menuconfig option to enable/disable route hook in matter #26830
chshu
merged 1 commit into
project-chip:master
from
wqx6:esp32/route_hook_menuconfig_option
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
May 25, 2023 08:15
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
May 25, 2023 08:15
PR #26830: Size comparison from 9f43988 to 2301de9 Increases (16 builds for bl602, bl702, cyw30739, esp32, psoc6, telink)
Decreases (6 builds for cyw30739, efr32, esp32, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
May 25, 2023
wqx6
force-pushed
the
esp32/route_hook_menuconfig_option
branch
from
May 29, 2023 04:22
2301de9
to
b4414a9
Compare
PR #26830: Size comparison from cfb9994 to b4414a9 Increases (4 builds for bl602, qpg, telink)
Decreases (13 builds for bl702, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
May 31, 2023
chshu
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need to add a menuconfig option so that we can disable route hook and realize it in other task.
Changes
Add the menuconfig option to enable/disable route hook in matter.