Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use controller exception in Java controller" #26799

Merged
merged 1 commit into from
May 24, 2023
Merged

Revert "Use controller exception in Java controller" #26799

merged 1 commit into from
May 24, 2023

Conversation

yunhanw-google
Copy link
Contributor

Reverts #26708

@pullapprove pullapprove bot requested review from turon and vijs May 24, 2023 16:49
@pullapprove pullapprove bot requested review from vivien-apple and woody-apple May 24, 2023 16:49
@andy31415 andy31415 merged commit bf95967 into master May 24, 2023
@pullapprove pullapprove bot added review - pending and removed examples hotfix urgent fix needed, can bypass review controller labels May 24, 2023
@andy31415 andy31415 deleted the revert-26708-feature/improve_java_controller branch May 24, 2023 16:50
@github-actions
Copy link

github-actions bot commented May 24, 2023 •
edited
Loading

PR #26799: Size comparison from 86267e6 to b58ef6d

Increases (8 builds for esp32, nrfconnect, psoc6, qpg, telink)
platform target config section 86267e6 b58ef6d change % change
esp32 all-clusters-app c3devkit (read only) 1054298 1054300 2 0.0
.flash.text 1054298 1054300 2 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 779276 779280 4 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 23388760 23388761 1 0.0
qpg lighting-app qpg6105+debug (read/write) 1170696 1170704 8 0.0
.text 617796 617804 8 0.0
telink light-switch-app tlsr9518adk80d text 596016 596020 4 0.0
lighting-app-shell tlsr9518adk80d text 720766 720770 4 0.0
lock-app tlsr9518adk80d text 610054 610056 2 0.0
window-covering tlsr9518adk80d text 593422 593424 2 0.0
Decreases (13 builds for bl702, efr32, nrfconnect, psoc6, telink)
platform target config section 86267e6 b58ef6d change % change
bl702 lighting-app bl702 (read/write) 1188207 1188191 -16 -0.0
.debug_info 42151095 42151094 -1 -0.0
.text 966754 966752 -2 -0.0
bl702+rpc .debug_info 47077155 47077154 -1 -0.0
.text 1040142 1040140 -2 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1068776 1068768 -8 -0.0
.text 892452 892444 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 808684 808680 -4 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 23224088 2322408 -1 -0.0
telink bridge-app tlsr9518adk80d (read/write) 924992 924984 -8 -0.0
text 638738 638736 -2 -0.0
contact-sensor-app tlsr9518adk80d text 581398 581394 -4 -0.0
lighting-app tlsr9518adk80d text 655732 655730 -2 -0.0
lighting-app-rpc tlsr9518adk80d text 700188 700186 -2 -0.0
pump-app tlsr9518adk80d text 587564 587562 -2 -0.0
pump-controller-app tlsr9518adk80d text 577688 577684 -4 -0.0
temperature-measurement-app tlsr9518adk80d text 573392 573388 -4 -0.0
thermostat tlsr9518adk80d (read/write) 877396 877388 -8 -0.0
text 598178 598174 -4 -0.0
Full report (40 builds for bl602, bl702, cyw30739, efr32, esp32, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 86267e6 b58ef6d change % change
bl602 lighting-app bl602 (read/write) 1356414 1356414 0 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1036548 1036548 0 0.0
bl602+rpc (read/write) 1402682 1402682 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067904 1067904 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1188207 1188191 -16 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1555753 1555753 0 0.0
.debug_aranges 136024 136024 0 0.0
.debug_frame 500368 500368 0 0.0
.debug_info 42151095 42151094 -1 -0.0
.debug_line 5370674 5370674 0 0.0
.debug_loc 3495982 3495982 0 0.0
.debug_ranges 375576 375576 0 0.0
.debug_str 3834243 3834243 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107168 107168 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582212 582212 0 0.0
.symtab 175632 175632 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
966754 966752 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276995 1276995 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1714736 1714736 0 0.0
.debug_aranges 144312 144312 0 0.0
.debug_frame 528380 528380 0 0.0
.debug_info 47077155 47077154 -1 -0.0
.debug_line 5786591 5786591 0 0.0
.debug_loc 3698814 3698814 0 0.0
.debug_ranges 400936 400936 0 0.0
.debug_str 4259760 4259760 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121248 121248 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 643532 643532 0 0.0
.symtab 194128 194128 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1040142 1040140 -2 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 524595 524595 0 0.0
.app_xip_area 417389 417389 0 0.0
.bss 62184 62184 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 529299 529299 0 0.0
.app_xip_area 416789 416789 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566307 566307 0 0.0
.app_xip_area 459861 459861 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 531075 531075 0 0.0
.app_xip_area 422061 422061 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 963988 963988 0 0.0
.bss 179680 179680 0 0.0
.data 2136 2136 0 0.0
.text 782152 782152 0 0.0
BRD4187C (read/write) 1000992 1000992 0 0.0
.bss 159412 159412 0 0.0
.data 2780 2780 0 0.0
.text 838780 838780 0 0.0
lock-app BRD4161A+wf200 (read/write) 1068776 1068768 -8 -0.0
.bss 174152 174152 0 0.0
.data 2152 2152 0 0.0
.text 892452 892444 -8 -0.0
window-app BRD4187C (read/write) 1076260 1076260 0 0.0
.bss 143884 143884 0 0.0
.data 2676 2676 0 0.0
.text 929680 929680 0 0.0
esp32 all-clusters-app c3devkit (read only) 1054298 1054300 2 0.0
(read/write) 1583808 1583808 0 0.0
.dram0.bss 77192 77192 0 0.0
.dram0.data 13964 13964 0 0.0
.flash.rodata 213512 213512 0 0.0
.flash.text 1054298 1054300 2 0.0
.iram0.text 76538 76538 0 0.0
m5stack (read only) 1101803 1101803 0 0.0
(read/write) 492970 492970 0 0.0
.dram0.bss 82208 82208 0 0.0
.dram0.data 34300 34300 0 0.0
.flash.rodata 241308 241308 0 0.0
.flash.text 1096419 1096419 0 0.0
.iram0.text 126055 126055 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2495368 2495368 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1458052 1458052 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1178080 1178080 0 0.0
bss 155621 155621 0 0.0
rodata 133072 133072 0 0.0
text 808684 808680 -4 -0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1437808 1437808 0 0.0
bss 135361 135361 0 0.0
rodata 229088 229088 0 0.0
text 779276 779280 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1124316 1124316 0 0.0
bss 154773 154773 0 0.0
rodata 109836 109836 0 0.0
text 778984 778984 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840616 840616 0 0.0
(read/write) 1709188 1709188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190164 190164 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1286148 1286148 0 0.0
.debug_aranges 131752 131752 0 0.0
.debug_frame 438004 438004 0 0.0
.debug_info 28331535 28331535 0 0.0
.debug_line 3814104 3814104 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2066504 2066504 0 0.0
.debug_rnglists 130781 130781 0 0.0
.debug_str 3771585 3771585 0 0.0
.heap 840616 840616 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 719999 719999 0 0.0
.symtab 467904 467904 0 0.0
.text 1508076 1508076 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841424 841424 0 0.0
(read/write) 1650252 1650252 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189364 189364 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1275887 1275887 0 0.0
.debug_aranges 131000 131000 0 0.0
.debug_frame 440444 440444 0 0.0
.debug_info 27951096 27951096 0 0.0
.debug_line 3827304 3827304 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2057416 2057416 0 0.0
.debug_rnglists 129730 129730 0 0.0
.debug_str 3760344 3760344 0 0.0
.heap 841424 841424 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 676366 676366 0 0.0
.symtab 452352 452352 0 0.0
.text 1449948 1449948 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849736 849736 0 0.0
(read/write) 1571260 1571260 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181220 181220 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2384 2384 0 0.0
.debug_abbrev 1108717 1108717 0 0.0
.debug_aranges 121032 121032 0 0.0
.debug_frame 403276 403276 0 0.0
.debug_info 23224088 2322408 -1 -0.0
.debug_line 3388394 3388394 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1887303 1887303 0 0.0
.debug_rnglists 119267 119267 0 0.0
.debug_str 3566363 3566363 0 0.0
.heap 849736 849736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 591746 591746 0 0.0
.symtab 414352 414352 0 0.0
.text 1379268 1379268 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821952 821952 0 0.0
(read/write) 1627876 1627876 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208996 208996 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1107835 1107835 0 0.0
.debug_aranges 121536 121536 0 0.0
.debug_frame 405368 405368 0 0.0
.debug_info 23388760 23388761 1 0.0
.debug_line 3384913 3384913 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1900776 1900776 0 0.0
.debug_rnglists 119723 119723 0 0.0
.debug_str 3581381 3581381 0 0.0
.heap 821952 821952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 595760 595760 0 0.0
.symtab 416688 416688 0 0.0
.text 1408100 1408100 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1170696 1170704 8 0.0
.bss 99928 99928 0 0.0
.data 856 856 0 0.0
.text 617796 617804 8 0.0
lock-app qpg6105+debug (read/write) 1139884 1139884 0 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586984 586984 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1011268 1011268 0 0.0
bss 98944 98944 0 0.0
text 687230 687230 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 946984 946984 0 0.0
bss 97996 97996 0 0.0
text 649108 649108 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 924992 924984 -8 -0.0
bss 100212 100212 0 0.0
text 638738 638736 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 856216 856216 0 0.0
bss 89888 89888 0 0.0
text 581398 581394 -4 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 872512 872512 0 0.0
bss 90044 90044 0 0.0
text 596016 596020 4 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 940132 940132 0 0.0
bss 98232 98232 0 0.0
text 655732 655730 -2 -0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951512 951512 0 0.0
bss 102480 102480 0 0.0
text 663256 663256 0 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1008556 1008556 0 0.0
bss 99796 99796 0 0.0
text 700188 700186 -2 -0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1040988 1040988 0 0.0
bss 110880 110880 0 0.0
text 720766 720770 4 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 911268 911268 0 0.0
bss 90540 90540 0 0.0
text 610054 610056 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 878808 878808 0 0.0
bss 91152 91152 0 0.0
text 603324 603324 0 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 862212 862212 0 0.0
bss 90008 90008 0 0.0
text 587564 587562 -2 -0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 849008 849008 0 0.0
bss 89808 89808 0 0.0
text 577688 577684 -4 -0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 845232 845232 0 0.0
bss 89728 89728 0 0.0
text 573392 573388 -4 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877396 877388 -8 -0.0
bss 91448 91448 0 0.0
text 598178 598174 -4 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873552 873552 0 0.0
bss 91844 91844 0 0.0
text 593422 593424 2 0.0

yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this pull request May 24, 2023
@yunhanw-google
Revert "Revert "Use controller exception in Java controller (project-…
d4ed344 
…chip#26708)" (project-chip#26799)"

This reverts commit bf95967.
yunhanw-google added a commit that referenced this pull request May 25, 2023
@yunhanw-google
Reland Use controller exception in Java controller (#26802)
3cafe02 
* Revert "Revert "Use controller exception in Java controller (#26708)" (#26799)"

This reverts commit bf95967.

* fix the type inside cluster exception

* Add missing L  fully-qualified-class for controller exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunhanw-google @andy31415