[chiptool.py] Add some mechanism to add additional custom pseudo clus… #26694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
vijs,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
vivien-apple
force-pushed
the
ChipToolPy_AddAnOptionToLoadCustomPseudoClusters
branch
from
7d89c48 to
58477c5
Compare
|
PR #26694: Size comparison from 682f348 to 58477c5 Increases (10 builds for bl602, bl702, esp32, psoc6, telink)
Decreases (5 builds for cc32xx, efr32, psoc6, telink)
Full report (55 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
bzbarsky-apple
approved these changes
May 19, 2023
…ters by using a custom folder
vivien-apple
force-pushed
the
ChipToolPy_AddAnOptionToLoadCustomPseudoClusters
branch
from
58477c5 to
c6ed941
Compare
|
PR #26694: Size comparison from bfa0580 to c6ed941 Increases (11 builds for bl602, bl702, psoc6, telink)
Decreases (8 builds for cc32xx, efr32, esp32, k32w, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ters by using a custom folder
Problem
This PR adds an option to
chiptool.pycalledadditional_pseudo_clusters_directorythat let the user specify a directory containing custom pseudo clusters that can be used to extends the YAML syntax.Such an example of such a cluster has been added in
scripts/tests/yaml/extensionsand this is the default option ofchiptool.py.Additionally
src/app/tests/suites/TestExampleCluster.yamlhas been added to validate that it does works.The current thinking is that there is a long tail of test steps that have a single use case and it makes it not always obvious to add an extra keyword for those.
The current mechanism should let the TH team implement custom methods when needed in order to automate the target test instead of having to run it manually because one or two keywords are not implemented yet.