-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix asr platform issue #26645
fix asr platform issue #26645
Conversation
PR #26645: Size comparison from ca83f16 to ea6ae2a Increases (12 builds for bl602, bl702, efr32, psoc6, telink)
Decreases (7 builds for cyw30739, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26645: Size comparison from c520917 to adb375a Increases (5 builds for bl602, esp32, psoc6, telink)
Decreases (8 builds for cc32xx, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear, I was not asking you to remove mEventMutex, just asking that we use it consistently... But I guess not having it at all is consistent.
1,modify PlatformManagerImpl implementation 2,bump third_party/asr/xxx/asr_sdk 3,remove unless code in SystemTimeSupport
b1bd609
to
3cc4580
Compare
PR #26645: Size comparison from e75e729 to 3cc4580 Increases (12 builds for bl602, cc32xx, esp32, k32w, psoc6, telink)
Decreases (9 builds for cyw30739, efr32, esp32, k32w, nrfconnect, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@bzbarsky-apple hi, can this be safely merged? |
@tx2rx PRs generally need two reviews from two different companies. See the "Pending" pullapprove CI job. Concretely: I cannot merge this PR until it has another review. |
PR #26645: Size comparison from c24294a to 5c66c8c Increases (7 builds for bl602, bl702, nrfconnect, telink)
Decreases (13 builds for bl602, bl702, cc32xx, efr32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
hi @bzbarsky-apple ,we remove some unused implemention in DiagnosticDataProviderImpl, these functions are not implemented yet, and should return failure. |
PR #26645: Size comparison from 014166c to 0a36d46 Increases (26 builds for cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for bl702, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
fix #26637
1,modify PlatformManagerImpl implementation
2,bump third_party/asr/xxx/asr_sdk
3,remove unless code in SystemTimeSupport