-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Replaceable Monitoring clusters on the "Feature" name. #26613
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:replaceable-feature-naming
May 17, 2023
Merged
Align Replaceable Monitoring clusters on the "Feature" name. #26613
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:replaceable-feature-naming
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
May 16, 2023 17:10
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple and
xylophone21
May 16, 2023 17:10
pullapprove
bot
requested review from
younghak-hwang,
yufengwangca and
yunhanw-google
May 16, 2023 17:10
PR #26613: Size comparison from 06921da to a082df3 Increases (10 builds for esp32, nrfconnect, psoc6, telink)
Decreases (11 builds for bl602, bl702, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
We generally want to move all feature maps to this.
bzbarsky-apple
force-pushed
the
replaceable-feature-naming
branch
from
May 17, 2023 14:44
a082df3
to
9370210
Compare
tehampson
approved these changes
May 17, 2023
jmartinez-silabs
approved these changes
May 17, 2023
PR #26613: Size comparison from 367404f to 9370210 Increases (9 builds for cc32xx, esp32, nrfconnect, psoc6, telink)
Decreases (17 builds for bl602, bl702, efr32, esp32, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We generally want to move all feature maps to this.