[Silabs] [EFR32] Refactor 917 NCP and 917 SoC Bluetooth "DriveBLEState" function and bugfix RS9116 Stop Advertising #26450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/shgutte/connectedhomeip into bugfix/rs9116_stop_ble_adverstising
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran and
hawk248
pullapprove
bot
requested review from
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #26450: Size comparison from 7bbd64d to 685df7e Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
jmartinez-silabs
requested changes
May 9, 2023
jmartinez-silabs
approved these changes
May 10, 2023
andy31415
approved these changes
May 10, 2023
shgutte
added a commit
to shgutte/connectedhomeip
that referenced
this pull request
Jun 7, 2023
…e" function and bugfix RS9116 Stop Advertising (project-chip#26450) * Refactor 917 NCP and 917 SoC bluetooth to use the same implementation file * Restyled by gn * Added changes for coding standard * Adds fix for the BLE stop advertising * Removing Stop BLE adversting for Sleepy Apps * Restyled by clang-format * Refactor 917 NCP and 917 SoC bluetooth to use the same implementation file * Added changes for coding standard * Adds fix for the BLE stop advertising * Removing Stop BLE adversting for Sleepy Apps * Restyled by clang-format * Removed the additional comments * Added build fox log error --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is DriverBLEState function code flow is not working properly for RS9117 and RS9116
Fixes added
Fixed the code flow of the DriverBLEState function and fix the Stop Advertisement issue
Testing
I tested with all combinations of RS9116 and RS9117.