Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we don't trash our userinfo after we get it and before we send it. #26373

Merged
merged 1 commit into from
May 8, 2023
Merged

Make sure we don't trash our userinfo after we get it and before we send it. #26373

merged 1 commit into from
May 8, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

findOccupiedUserSlot can end up overwriting some of the buffers that emberAfPluginDoorLockGetUser uses, so we need to make sure we call findOccupiedUserSlot before emberAfPluginDoorLockGetUser (or after we are done using the output from emberAfPluginDoorLockGetUser).

@github-actions github-actions bot added the app label May 4, 2023
@bzbarsky-apple
Make sure we don't trash our userinfo after we get it and before we s…
8243d18 
…end it.

findOccupiedUserSlot can end up overwriting some of the buffers that
emberAfPluginDoorLockGetUser uses, so we need to make sure we call
findOccupiedUserSlot before emberAfPluginDoorLockGetUser (or after we are done
using the output from emberAfPluginDoorLockGetUser).
@bzbarsky-apple bzbarsky-apple force-pushed the door-lock-userinfo-fix branch from 9c4ee5f to 8243d18 Compare May 4, 2023 19:34
@github-actions
Copy link

github-actions bot commented May 4, 2023

PR #26373: Size comparison from de1c64a to 8243d18

Increases (1 build for cc32xx)
platform target config section de1c64a 8243d18 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19522697 19522708 11 0.0
.debug_line 2666219 2666222 3 0.0
.debug_loclists 1488771 1488809 38 0.0
Full report (1 build for cc32xx)
platform target config section de1c64a 8243d18 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604866 604866 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957005 957005 0 0.0
.debug_aranges 101104 101104 0 0.0
.debug_frame 341416 341416 0 0.0
.debug_info 19522697 19522708 11 0.0
.debug_line 2666219 2666222 3 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1488771 1488809 38 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94291 94291 0 0.0
.debug_str 3100491 3100491 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104346 104346 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 482872 482872 0 0.0
.symtab 287120 287120 0 0.0
.text 498396 498396 0 0.0

jrhees-cae
jrhees-cae approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@jrhees-cae jrhees-cae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes on my local device. LGTM

@andy31415 andy31415 merged commit e523193 into project-chip:master May 8, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request May 8, 2023
@bzbarsky-apple
Make sure we don't trash our userinfo after we get it and before we s…
c32680c 
…end it. (project-chip#26373)

findOccupiedUserSlot can end up overwriting some of the buffers that
emberAfPluginDoorLockGetUser uses, so we need to make sure we call
findOccupiedUserSlot before emberAfPluginDoorLockGetUser (or after we are done
using the output from emberAfPluginDoorLockGetUser).
@bzbarsky-apple bzbarsky-apple deleted the door-lock-userinfo-fix branch May 8, 2023 16:18
@andy31415 andy31415 mentioned this pull request May 8, 2023
Merged
andy31415 pushed a commit that referenced this pull request May 8, 2023
@bzbarsky-apple
Make sure we don't trash our userinfo after we get it and before we s…
23e69c3 
…end it. (#26373) (#26421)

findOccupiedUserSlot can end up overwriting some of the buffers that
emberAfPluginDoorLockGetUser uses, so we need to make sure we call
findOccupiedUserSlot before emberAfPluginDoorLockGetUser (or after we are done
using the output from emberAfPluginDoorLockGetUser).
Damian-Nordic pushed a commit to Damian-Nordic/connectedhomeip that referenced this pull request Jun 1, 2023
@bzbarsky-apple @ArekBalysNordic
[nrf fromtree] Make sure we don't trash our userinfo after we get it …
da3bcc8 
…and before we send it. (project-chip#26373) (project-chip#26421)

findOccupiedUserSlot can end up overwriting some of the buffers that
emberAfPluginDoorLockGetUser uses, so we need to make sure we call
findOccupiedUserSlot before emberAfPluginDoorLockGetUser (or after we are done
using the output from emberAfPluginDoorLockGetUser).

cherry-picked from: 23e69c3
maciejbaczmanski pushed a commit to maciejbaczmanski/connectedhomeip that referenced this pull request Jul 15, 2024
@bzbarsky-apple @Damian-Nordic
[nrf fromtree] Make sure we don't trash our userinfo after we get it …
9b427d6 
…and before we send it. (project-chip#26373) (project-chip#26421)

findOccupiedUserSlot can end up overwriting some of the buffers that
emberAfPluginDoorLockGetUser uses, so we need to make sure we call
findOccupiedUserSlot before emberAfPluginDoorLockGetUser (or after we are done
using the output from emberAfPluginDoorLockGetUser).

cherry-picked from: 23e69c3
maciejbaczmanski pushed a commit to maciejbaczmanski/connectedhomeip that referenced this pull request Jul 15, 2024
@kkasperczyk-no
Revert "[nrf fromtree] Make sure we don't trash our userinfo after we…
2f3d58c 
… get it and before we send it. (project-chip#26373) (project-chip#26421)"

This reverts commit 9b427d6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtung-apple jtung-apple jtung-apple approved these changes

@jrhees-cae jrhees-cae jrhees-cae approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app cherry picked to 1.1 review - approved v1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @andy31415 @jrhees-cae @jtung-apple