-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chiptool.py] Add --trace_file, --trace_decode, --node_id, --continue… #26333
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Chiptoolpy_AddMissingTestsArguments
May 5, 2023
Merged
[chiptool.py] Add --trace_file, --trace_decode, --node_id, --continue… #26333
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Chiptoolpy_AddMissingTestsArguments
May 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
May 2, 2023 15:19
pullapprove
bot
requested review from
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 2, 2023 15:19
mikaelhm
reviewed
May 2, 2023
examples/chip-tool/py_matter_chip_tool_adapter/matter_chip_tool_adapter/encoder.py
Outdated
Show resolved
Hide resolved
PR #26333: Size comparison from 34b2a80 to d676ed8 Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, with the 0x bit resolved for node ids.
examples/chip-tool/py_matter_chip_tool_adapter/matter_chip_tool_adapter/encoder.py
Outdated
Show resolved
Hide resolved
vivien-apple
force-pushed
the
Chiptoolpy_AddMissingTestsArguments
branch
from
May 2, 2023 17:01
d676ed8
to
e8d9817
Compare
…OnFailure, --timeout, --delayInMs supports
vivien-apple
force-pushed
the
Chiptoolpy_AddMissingTestsArguments
branch
from
May 2, 2023 17:03
e8d9817
to
95e5647
Compare
mikaelhm
approved these changes
May 2, 2023
PR #26333: Size comparison from 7be1954 to 95e5647 Decreases (2 builds for cc32xx, qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
I have tested this out with the Matter TH and it does work as expected, fixing #26303 |
andy31415
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…OnFailure, --timeout, --delayInMs supports
Problem
Those arguments are not parsed correctly by
chiptool.py
at the moment, which prevents the test harness to be updated.Fix #26303