Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chiptool.py] Add --trace_file, --trace_decode, --node_id, --continue… #26333

Conversation

vivien-apple
Copy link
Contributor

…OnFailure, --timeout, --delayInMs supports

Problem

Those arguments are not parsed correctly by chiptool.py at the moment, which prevents the test harness to be updated.

Fix #26303

@github-actions
Copy link

github-actions bot commented May 2, 2023

PR #26333: Size comparison from 34b2a80 to d676ed8

Full report (1 build for cc32xx)
platform target config section 34b2a80 d676ed8 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604426 604426 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956872 956872 0 0.0
.debug_aranges 101056 101056 0 0.0
.debug_frame 341168 341168 0 0.0
.debug_info 19511283 19511283 0 0.0
.debug_line 2664965 2664965 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1486884 1486884 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94239 94239 0 0.0
.debug_str 3068127 3068127 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104298 104298 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 480350 480350 0 0.0
.symtab 287024 287024 0 0.0
.text 498004 498004 0 0.0

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with the 0x bit resolved for node ids.

scripts/py_matter_yamltests/matter_yamltests/runner.py Outdated Show resolved Hide resolved
scripts/tests/yaml/runner.py Outdated Show resolved Hide resolved
@vivien-apple vivien-apple force-pushed the Chiptoolpy_AddMissingTestsArguments branch from d676ed8 to e8d9817 Compare May 2, 2023 17:01
@vivien-apple vivien-apple force-pushed the Chiptoolpy_AddMissingTestsArguments branch from e8d9817 to 95e5647 Compare May 2, 2023 17:03
@vivien-apple vivien-apple enabled auto-merge (squash) May 2, 2023 17:03
@github-actions
Copy link

github-actions bot commented May 2, 2023

PR #26333: Size comparison from 7be1954 to 95e5647

Decreases (2 builds for cc32xx, qpg)
platform target config section 7be1954 95e5647 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19511285 19511284 -1 -0.0
qpg lighting-app qpg6105+debug (read/write) 1167616 1167608 -8 -0.0
.text 614716 614708 -8 -0.0
Full report (4 builds for cc32xx, mbed, qpg)
platform target config section 7be1954 95e5647 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604426 604426 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956872 956872 0 0.0
.debug_aranges 101056 101056 0 0.0
.debug_frame 341168 341168 0 0.0
.debug_info 19511285 19511284 -1 -0.0
.debug_line 2664965 2664965 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1486884 1486884 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94239 94239 0 0.0
.debug_str 3068127 3068127 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104298 104298 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 480350 480350 0 0.0
.symtab 287024 287024 0 0.0
.text 498004 498004 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2496432 2496432 0 0.0
.bss 216296 216296 0 0.0
.data 5144 5144 0 0.0
.text 1459116 1459116 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1167616 1167608 -8 -0.0
.bss 99632 99632 0 0.0
.data 856 856 0 0.0
.text 614716 614708 -8 -0.0
lock-app qpg6105+debug (read/write) 1136984 1136984 0 0.0
.bss 94784 94784 0 0.0
.data 852 852 0 0.0
.text 584080 584080 0 0.0

@mikaelhm
Copy link
Contributor

mikaelhm commented May 4, 2023

I have tested this out with the Matter TH and it does work as expected, fixing #26303

@vivien-apple vivien-apple merged commit 8b05d8e into project-chip:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chiptool.py] chiptool.py tests command missing support for several command line arguments used by Matter TH
4 participants