-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Mismatch in value type of light-sensor-type attribute of Illuminance Measurement Cluster. #26290
Bugfix: Mismatch in value type of light-sensor-type attribute of Illuminance Measurement Cluster. #26290
Conversation
PR #26290: Size comparison from e62d3dd to c2690d2 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with the change. But the table in the spec should be updated to indicate this define type for the LightSensorType attribute instead of enum8
Illuminance Measurement Attributes
src/app/zap-templates/zcl/data-model/chip/illuminance-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
It might be worth coordinating this effort with the in-flight editorial for this cluster https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6469 so we do not have to change this name twice? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@riwaghe This needs to be rebased/merged to tip for those generated code file conflicts. Let me know if you want me to do that, please. |
14f8541
to
88cec48
Compare
PR #26290: Size comparison from 22de5a0 to 88cec48 Increases (18 builds for bl602, bl702, cc32xx, esp32, linux, psoc6, qpg, telink)
Decreases (8 builds for bl602, cc13x4_26x4, efr32, esp32, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
88cec48
to
ad71ea3
Compare
PR #26290: Size comparison from e2b9cad to ad71ea3 Increases (6 builds for bl602, bl702, cc32xx, nrfconnect, qpg)
Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)
|
…minace measurment cluster
ad71ea3
to
c0ee722
Compare
PR #26290: Size comparison from 25ba372 to c0ee722 Increases (18 builds for bl702, cc32xx, esp32, linux, psoc6, qpg, telink)
Decreases (14 builds for bl602, bl702, cyw30739, efr32, esp32, nrfconnect, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Fixed Illuminance Measurement Cluster data model using proper enum type, now it uses the correctly defined type.