Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from wasRemoved to isSupported for Darwin codegen. #26146

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Switch from wasRemoved to isSupported for Darwin codegen. #26146

merged 3 commits into from
Apr 20, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

isSupported allows things to be marked as "provisional", which unlike "removed" can be overridden by a later "introduced" annotation.

@bzbarsky-apple bzbarsky-apple marked this pull request as draft April 18, 2023 15:35
@github-actions
Copy link

PR #26146: Size comparison from 2bedaf3 to 9ff312f

Increases (2 builds for bl602)
platform target config section 2bedaf3 9ff312f change % change
bl602 lighting-app bl602 .text 1031686 1031688 2 0.0
bl602+rpc .text 1062774 1062776 2 0.0
Decreases (8 builds for bl702, efr32, k32w, psoc6)
platform target config section 2bedaf3 9ff312f change % change
bl702 lighting-app bl702 .debug_info 4074566 40745661 -2 -0.0
.text 959520 959516 -4 -0.0
bl702+rpc .debug_info 45237658 45237657 -1 -0.0
.text 1032440 1032438 -2 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1071280 1071272 -8 -0.0
.text 895984 895976 -8 -0.0
k32w light k32w0+release (read/write) 675652 675636 -16 -0.0
.text 576852 576836 -16 -0.0
lock k32w0+release (read/write) 630384 630368 -16 -0.0
.text 549972 549956 -16 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 28117347 2811734 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27576657 27576656 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 23186565 23186564 -1 -0.0
Full report (30 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, psoc6, qpg)
platform target config section 2bedaf3 9ff312f change % change
bl602 lighting-app bl602 (read/write) 1350526 1350526 0 0.0
.bss 87862 87862 0 0.0
.data 9648 9648 0 0.0
.text 1031686 1031688 2 0.0
bl602+rpc (read/write) 1396514 1396514 0 0.0
.bss 95910 95910 0 0.0
.data 10040 10040 0 0.0
.text 1062774 1062776 2 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1179543 1179543 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67577 67577 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1549370 1549370 0 0.0
.debug_aranges 134672 134672 0 0.0
.debug_frame 495172 495172 0 0.0
.debug_info 4074566 40745661 -2 -0.0
.debug_line 5309220 5309220 0 0.0
.debug_loc 3444130 3444130 0 0.0
.debug_ranges 376400 376400 0 0.0
.debug_str 3596774 3596774 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106048 106048 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 573725 573725 0 0.0
.symtab 174288 174288 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 959520 959516 -4 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1267643 1267643 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75609 75609 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1699986 1699986 0 0.0
.debug_aranges 142880 142880 0 0.0
.debug_frame 523004 523004 0 0.0
.debug_info 45237658 45237657 -1 -0.0
.debug_line 5716367 5716367 0 0.0
.debug_loc 3644588 3644588 0 0.0
.debug_ranges 401376 401376 0 0.0
.debug_str 4020996 4020996 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 119904 119904 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 634727 634727 0 0.0
.symtab 192688 192688 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1032440 1032438 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 683351 683351 0 0.0
(read/write) 167912 167912 0 0.0
.bss 80956 80956 0 0.0
.data 3336 3336 0 0.0
.rodata 87071 87071 0 0.0
.text 595964 595964 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646615 646615 0 0.0
(read/write) 157608 157608 0 0.0
.bss 80156 80156 0 0.0
.data 3336 3336 0 0.0
.rodata 76863 76863 0 0.0
.text 569432 569432 0 0.0
lock-ftd LP_CC2652R7 (read only) 679135 679135 0 0.0
(read/write) 169576 169576 0 0.0
.bss 78492 78492 0 0.0
.data 3300 3300 0 0.0
.rodata 75751 75751 0 0.0
.text 602904 602904 0 0.0
lock-mtd LP_CC2652R7 (read only) 667027 667027 0 0.0
(read/write) 176860 176860 0 0.0
.bss 73668 73668 0 0.0
.data 3300 3300 0 0.0
.rodata 102635 102635 0 0.0
.text 563912 563912 0 0.0
pump-app LP_CC2652R7 (read only) 691859 691859 0 0.0
(read/write) 157596 157596 0 0.0
.bss 78468 78468 0 0.0
.data 3264 3264 0 0.0
.rodata 89867 89867 0 0.0
.text 601512 601512 0 0.0
pump-controller-app LP_CC2652R7 (read only) 676755 676755 0 0.0
(read/write) 172836 172836 0 0.0
.bss 78604 78604 0 0.0
.data 3288 3288 0 0.0
.rodata 85619 85619 0 0.0
.text 590656 590656 0 0.0
shell LP_CC2652R7 (read only) 676198 676198 0 0.0
(read/write) 177136 177136 0 0.0
.bss 83028 83028 0 0.0
.data 3332 3332 0 0.0
.rodata 85358 85358 0 0.0
.text 590528 590528 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 536210 536210 0 0.0
.app_xip_area 416788 416788 0 0.0
.bss 61856 61856 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 540634 540634 0 0.0
.app_xip_area 415924 415924 0 0.0
.bss 67136 67136 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577394 577394 0 0.0
.app_xip_area 458732 458732 0 0.0
.bss 61144 61144 0 0.0
.data 680 680 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 541786 541786 0 0.0
.app_xip_area 420548 420548 0 0.0
.bss 63640 63640 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1018040 1018040 0 0.0
.bss 178684 178684 0 0.0
.data 2128 2128 0 0.0
.text 837208 837208 0 0.0
lock-app BRD4161A+wf200 (read/write) 1071280 1071272 -8 -0.0
.bss 173132 173132 0 0.0
.data 2144 2144 0 0.0
.text 895984 895976 -8 -0.0
lighting-app BRD4187C (read/write) 1026080 1026080 0 0.0
.bss 159200 159200 0 0.0
.data 2780 2780 0 0.0
.text 839504 839504 0 0.0
window-app BRD4187C (read/write) 1141836 1141836 0 0.0
.bss 143632 143632 0 0.0
.data 2668 2668 0 0.0
.text 970940 970940 0 0.0
k32w contact k32w0+release (read/write) 676512 676512 0 0.0
.bss 65540 65540 0 0.0
.data 2208 2208 0 0.0
.text 577364 577364 0 0.0
light k32w0+release (read/write) 675652 675636 -16 -0.0
.bss 65204 65204 0 0.0
.data 2196 2196 0 0.0
.text 576852 576836 -16 -0.0
lock k32w0+release (read/write) 630384 630368 -16 -0.0
.bss 63276 63276 0 0.0
.data 2120 2120 0 0.0
.text 549972 549956 -16 -0.0
linux chip-tool-ipv6only arm64 (read only) 12162276 12162276 0 0.0
(read/write) 744888 744888 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 686760 686760 0 0.0
.dynamic 560 560 0 0.0
.got 15528 15528 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 567844 567844 0 0.0
.text 9826772 9826772 0 0.0
thermostat-no-ble arm64 (read only) 2501788 2501788 0 0.0
(read/write) 145320 145320 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77752 77752 0 0.0
.dynamic 560 560 0 0.0
.got 5352 5352 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 129384 129384 0 0.0
.text 2109456 2109456 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840848 840848 0 0.0
(read/write) 1760948 1760948 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189856 189856 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1259918 1259918 0 0.0
.debug_aranges 112000 112000 0 0.0
.debug_frame 377072 377072 0 0.0
.debug_info 28117347 2811734 -1 -0.0
.debug_line 3830247 3830247 0 0.0
.debug_loc 3737873 3737873 0 0.0
.debug_ranges 370008 370008 0 0.0
.debug_str 3553409 3553409 0 0.0
.heap 840848 840848 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 583331 583331 0 0.0
.symtab 426816 426816 0 0.0
.text 1560064 1560064 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841656 841656 0 0.0
(read/write) 1700996 1700996 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189056 189056 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1241782 1241782 0 0.0
.debug_aranges 111152 111152 0 0.0
.debug_frame 379156 379156 0 0.0
.debug_info 27576657 27576656 -1 -0.0
.debug_line 3833626 3833626 0 0.0
.debug_loc 3719943 3719943 0 0.0
.debug_ranges 367856 367856 0 0.0
.debug_str 3539328 3539328 0 0.0
.heap 841656 841656 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 542533 542533 0 0.0
.symtab 411632 411632 0 0.0
.text 1500920 1500920 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849920 849920 0 0.0
(read/write) 1614740 1614740 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180960 180960 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1077073 1077073 0 0.0
.debug_aranges 103360 103360 0 0.0
.debug_frame 349436 349436 0 0.0
.debug_info 22935012 22935012 0 0.0
.debug_line 3385047 3385047 0 0.0
.debug_loc 3394642 3394642 0 0.0
.debug_ranges 326320 326320 0 0.0
.debug_str 3337912 3337912 0 0.0
.heap 849920 849920 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477620 477620 0 0.0
.symtab 379264 379264 0 0.0
.text 1422928 1422928 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 822144 822144 0 0.0
(read/write) 1671900 1671900 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208720 208720 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1079305 1079305 0 0.0
.debug_aranges 103760 103760 0 0.0
.debug_frame 351128 351128 0 0.0
.debug_info 23186565 23186564 -1 -0.0
.debug_line 3386798 3386798 0 0.0
.debug_loc 3418543 3418543 0 0.0
.debug_ranges 328920 328920 0 0.0
.debug_str 3356473 3356473 0 0.0
.heap 822144 822144 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 481017 481017 0 0.0
.symtab 381456 381456 0 0.0
.text 1452312 1452312 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1166568 1166568 0 0.0
.bss 99308 99308 0 0.0
.data 856 856 0 0.0
.text 613668 613668 0 0.0
lock-app qpg6105+debug (read/write) 1136688 1136688 0 0.0
.bss 94452 94452 0 0.0
.data 860 860 0 0.0
.text 583784 583784 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the use-isSupported branch 2 times, most recently from 2a3d276 to a42ddde Compare April 18, 2023 17:17
@github-actions
Copy link

PR #26146: Size comparison from abfc298 to a42ddde

Decreases (1 build for cc32xx)
platform target config section abfc298 a42ddde change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20330829 20330828 -1 -0.0
Full report (1 build for cc32xx)
platform target config section abfc298 a42ddde change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643249 643249 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87792 87792 0 0.0
.debug_frame 302140 302140 0 0.0
.debug_info 20330829 20330828 -1 -0.0
.debug_line 2687904 2687904 0 0.0
.debug_loc 2838960 2838960 0 0.0
.debug_ranges 288072 288072 0 0.0
.debug_str 3042335 3042335 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104401 104401 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377963 377963 0 0.0
.symtab 256976 256976 0 0.0
.text 536728 536728 0 0.0

@bzbarsky-apple bzbarsky-apple marked this pull request as ready for review April 19, 2023 00:19
@bzbarsky-apple
Update ZAP to v2023.04.18-nightly to pick up isSupported.
f2e4525
@bzbarsky-apple
Switch from wasRemoved to isSupported for Darwin codegen.
87a8d8d 
isSupported allows things to be marked as "provisional", which unlike "removed"
can be overridden by a later "introduced" annotation.
@bzbarsky-apple
Stop depending on controller-clusters.zap state entirely, now that we…
243639d 
… can.
@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific change with platform owner review.

@bzbarsky-apple bzbarsky-apple merged commit a14e6fb into project-chip:master Apr 20, 2023
@bzbarsky-apple bzbarsky-apple deleted the use-isSupported branch April 20, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin examples fast track integrations review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @woody-apple