-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix restart of controllers that use fabric table storage. #26004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:commissioner-shutdown-configure-fabric-removal
Apr 7, 2023
Merged
Fix restart of controllers that use fabric table storage. #26004
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:commissioner-shutdown-configure-fabric-removal
Apr 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba676a1
to
9c2aa4e
Compare
PR #26004: Size comparison from efaf3aa to 9c2aa4e Full report (1 build for cc32xx)
|
jtung-apple
approved these changes
Apr 6, 2023
Right now controller shutdown clears out the fabric table entry in memory, but not in storage. After that memory and storage are out of sync, and various things that rely on the storage (like starting a new controller for the same fabric without providing all the certs and whatnot) end up failing. The fix is to make the Forget() call in controller shutdown configurable, so that consumers who rely on the storage can skip it.
9c2aa4e
to
57bb73f
Compare
PR #26004: Size comparison from b8201bb to 57bb73f Full report (1 build for cc32xx)
|
andy31415
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now controller shutdown clears out the fabric table entry in memory, but not in storage. After that memory and storage are out of sync, and various things that rely on the storage (like starting a new controller for the same fabric without providing all the certs and whatnot) end up failing.
The fix is to make the Forget() call in controller shutdown configurable, so that consumers who rely on the storage can skip it.