-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use -fmacro-prefix-map to tidy up CHIPError source file names #25939
Merged
ksperling-apple
merged 2 commits into
project-chip:master
from
ksperling-apple:macro-prefix-map
Apr 5, 2023
Merged
Use -fmacro-prefix-map to tidy up CHIPError source file names #25939
ksperling-apple
merged 2 commits into
project-chip:master
from
ksperling-apple:macro-prefix-map
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
lazarkov
April 3, 2023 05:08
PR #25939: Size comparison from 7ccd5d4 to dd87147 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #25939: Size comparison from 7ccd5d4 to 4e00d1a Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
ksperling-apple
force-pushed
the
macro-prefix-map
branch
from
April 3, 2023 22:08
4e00d1a
to
6241495
Compare
andy31415
approved these changes
Apr 3, 2023
bzbarsky-apple
approved these changes
Apr 3, 2023
PR #25939: Size comparison from bf6dc7b to 6241495 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
jtung-apple
approved these changes
Apr 3, 2023
This makes CHIPError source paths relative to chip_root, e.g. "src/core/*" instead ending up with long path prefixes relative to the build directory. Especially for the Darwin framework we otherwise end up with paths like "../../../../../../../../Sources/CHIPFramework/connectedhomeip/*"
ksperling-apple
force-pushed
the
macro-prefix-map
branch
from
April 5, 2023 02:12
6241495
to
ae36b04
Compare
PR #25939: Size comparison from 7c68de4 to ae36b04 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #25939: Size comparison from 7c68de4 to 4d75d75 Increases above 0.2%:
Increases (12 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (47 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes CHIPError source paths relative to chip_root, e.g.
"src/core/*"
instead of ending up with long path prefixes relative to the build directory. Especially for the Darwin framework we otherwise end up with paths like"../../../../../../../../Sources/CHIPFramework/connectedhomeip/*"
Also move warnings options from
OTHER_CFLAGS
toWARNING_CFLAGS
in the Xcode project.Depends on #25952 for android smoke tests to pass.