[Silabs] Enabling the sleepy device for EFR32 and rs911x combo #25519

chirag-silabs · 2023-03-07T10:14:05Z

Enabling the sleepy device changes for EFR32+RS911x combos

setting to EM1 mode during the spi communication and setting it back to EM2
RS9116 going to sleep based on the DTIM based interval

Verified locally using EFR32+RS9116

github-actions · 2023-03-16T04:36:55Z

PR #25519: Size comparison from 7a52877 to 7577f3d

Full report (1 build for cc32xx)

platform	target	config	section	`7a52877`	`7577f3d`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	645489	645489
			(read/write)	203848	203848
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197248	197248
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	930293	930293
			.debug_aranges	87384	87384
			.debug_frame	300248	300248
			.debug_info	20245968	20245968
			.debug_line	`2660979`	`2660979`
			.debug_loc	2804909	2804909
			.debug_ranges	283168	283168
			.debug_str	`3026947`	`3026947`
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	106009	106009
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	380271	380271
			.symtab	257312	257312
			.text	537360	537360

github-actions · 2023-03-16T14:02:50Z

PR #25519: Size comparison from 7a52877 to 505ead7

Increases (1 build for cc32xx)

platform	target	config	section	`7a52877`	`505ead7`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20245968	20245969	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`7a52877`	`505ead7`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	645489	645489	0
			(read/write)	203848	203848	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197248	197248	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930293	930293	0
			.debug_aranges	87384	87384	0
			.debug_frame	300248	300248	0
			.debug_info	20245968	20245969	1
			.debug_line	`2660979`	`2660979`	0
			.debug_loc	2804909	2804909	0
			.debug_ranges	283168	283168	0
			.debug_str	`3026947`	`3026947`	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	106009	106009	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	380271	380271	0
			.symtab	257312	257312	0
			.text	537360	537360	0

examples/platform/silabs/efr32/rs911x/hal/efx_spi.c

examples/platform/silabs/efr32/rs911x/rsi_wlan_config.h

src/platform/silabs/CHIPDevicePlatformConfig.h

jepenven-silabs

LGTM

github-actions · 2023-03-16T18:15:10Z

PR #25519: Size comparison from 7a52877 to 251f695

Full report (2 builds for cc32xx, mbed)

platform	target	config	section	`7a52877`	`251f695`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	645489	645489
			(read/write)	203848	203848
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197248	197248
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	930293	930293
			.debug_aranges	87384	87384
			.debug_frame	300248	300248
			.debug_info	20245968	20245968
			.debug_line	`2660979`	`2660979`
			.debug_loc	2804909	2804909
			.debug_ranges	283168	283168
			.debug_str	`3026947`	`3026947`
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	106009	106009
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	380271	380271
			.symtab	257312	257312
			.text	537360	537360
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	`2468312`	`2468312`
			.bss	215964	215964
			.data	5880	5880
			.text	1430956	1430956

mkardous-silabs

one nit left, but other wise good to go

examples/platform/silabs/efr32/rs911x/hal/rsi_hal_mcu_ioports.c

github-actions · 2023-03-19T06:10:31Z

PR #25519: Size comparison from 3edd101 to c675664

Decreases (1 build for cc32xx)

platform	target	config	section	`3edd101`	`c675664`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20265057	20265056	-1	-0.0

Full report (1 build for cc32xx)

platform	target	config	section	`3edd101`	`c675664`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	645945	645945	0	0.0
			(read/write)	203848	203848	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197248	197248	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	930399	930399	0	0.0
			.debug_aranges	87520	87520	0	0.0
			.debug_frame	300716	300716	0	0.0
			.debug_info	20265057	20265056	-1	-0.0
			.debug_line	2663587	2663587	0	0.0
			.debug_loc	2808805	2808805	0	0.0
			.debug_ranges	283608	283608	0	0.0
			.debug_str	`3036926`	`3036926`	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	106009	106009	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	381423	381423	0	0.0
			.symtab	257664	257664	0	0.0
			.text	537816	537816	0	0.0

github-actions · 2023-03-20T14:12:54Z

PR #25519: Size comparison from 3edd101 to d6ff6b7

Decreases (1 build for cc32xx)

platform	target	config	section	`3edd101`	`d6ff6b7`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	(read only)	645945	645601	-344	-0.1
			.debug_abbrev	930399	930289	-110	-0.0
			.debug_aranges	87520	87400	-120	-0.1
			.debug_frame	300716	300316	-400	-0.1
			.debug_info	20265057	20248009	-17048	-0.1
			.debug_line	2663587	2661469	-2118	-0.1
			.debug_loc	2808805	2805592	-3213	-0.1
			.debug_ranges	283608	283208	-400	-0.1
			.debug_str	`3036926`	3027174	-9752	-0.3
			.rodata	106009	105993	-16	-0.0
			.strtab	381423	380421	-1002	-0.3
			.symtab	257664	257408	-256	-0.1
			.text	537816	537488	-328	-0.1

Full report (1 build for cc32xx)

platform	target	config	section	`3edd101`	`d6ff6b7`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	645945	645601	-344	-0.1
			(read/write)	203848	203848	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197248	197248	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	930399	930289	-110	-0.0
			.debug_aranges	87520	87400	-120	-0.1
			.debug_frame	300716	300316	-400	-0.1
			.debug_info	20265057	20248009	-17048	-0.1
			.debug_line	2663587	2661469	-2118	-0.1
			.debug_loc	2808805	2805592	-3213	-0.1
			.debug_ranges	283608	283208	-400	-0.1
			.debug_str	`3036926`	3027174	-9752	-0.3
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	106009	105993	-16	-0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	381423	380421	-1002	-0.3
			.symtab	257664	257408	-256	-0.1
			.text	537816	537488	-328	-0.1

…ct-chip#25519) * enabling the sleepy device for EFR32 and rs911x combo * Restyled by whitespace * Restyled by clang-format * Restyled by gn * addressing review comments * 917 modifications and addressing some review comments * Adding comments on the DMA transactions * Restyled by clang-format * modifying the function signature * switch case modifications as per the suggestions * bugfix switch case missed break * addressing review comments * Restyled by clang-format * addressing review comments * restyle changes * Addressing review comments * sleepy devices when rs9116 ble is in use --------- Co-authored-by: Restyled.io <[email protected]>

github-actions bot added examples platform labels Mar 7, 2023

chirag-silabs and others added 3 commits March 16, 2023 09:42

Adding comments on the DMA transactions

33b9ed3

Restyled by clang-format

0e31397

modifying the function signature

2ed9e54

chirag-silabs force-pushed the feature/rs911x_sleepy branch from 74f065a to 2ed9e54 Compare March 16, 2023 04:13

chirag-silabs added 2 commits March 16, 2023 09:49

switch case modifications as per the suggestions

cfbeec1

bugfix switch case missed break

7577f3d

chirag-silabs and others added 2 commits March 16, 2023 19:15

addressing review comments

af13a6d

Restyled by clang-format

505ead7

jepenven-silabs reviewed Mar 16, 2023

View reviewed changes

examples/platform/silabs/efr32/rs911x/hal/efx_spi.c Outdated Show resolved Hide resolved

examples/platform/silabs/efr32/rs911x/rsi_wlan_config.h Show resolved Hide resolved

src/platform/silabs/CHIPDevicePlatformConfig.h Show resolved Hide resolved

chirag-silabs added 2 commits March 16, 2023 23:16

addressing review comments

98908be

restyle changes

251f695

jepenven-silabs approved these changes Mar 16, 2023

View reviewed changes

jepenven-silabs requested review from mkardous-silabs and removed request for pjzander-signify March 16, 2023 18:01

mkardous-silabs approved these changes Mar 16, 2023

View reviewed changes

examples/platform/silabs/efr32/rs911x/hal/rsi_hal_mcu_ioports.c Outdated Show resolved Hide resolved

chirag-silabs and others added 2 commits March 17, 2023 10:17

Addressing review comments

9d7467f

Merge branch 'master' into feature/rs911x_sleepy

c675664

sleepy devices when rs9116 ble is in use

d6ff6b7

jmartinez-silabs enabled auto-merge (squash) March 20, 2023 16:15

andy31415 approved these changes Mar 20, 2023

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Mar 20, 2023

jmartinez-silabs merged commit 4efc0f8 into project-chip:master Mar 20, 2023

rosahay-silabs deleted the feature/rs911x_sleepy branch May 15, 2023 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Silabs] Enabling the sleepy device for EFR32 and rs911x combo #25519

[Silabs] Enabling the sleepy device for EFR32 and rs911x combo #25519

chirag-silabs commented Mar 7, 2023

github-actions bot commented Mar 16, 2023

github-actions bot commented Mar 16, 2023

jepenven-silabs left a comment

github-actions bot commented Mar 16, 2023

mkardous-silabs left a comment

github-actions bot commented Mar 19, 2023

github-actions bot commented Mar 20, 2023

[Silabs] Enabling the sleepy device for EFR32 and rs911x combo #25519

[Silabs] Enabling the sleepy device for EFR32 and rs911x combo #25519

Conversation

chirag-silabs commented Mar 7, 2023

github-actions bot commented Mar 16, 2023

github-actions bot commented Mar 16, 2023

jepenven-silabs left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 16, 2023

mkardous-silabs left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 19, 2023

github-actions bot commented Mar 20, 2023