Make it easier to catch bugs in async command handling. #25402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If GetSubjectDescriptor or GetAccessingFabricIndex were called on a CommandHandler after the command handling had gone async, it would sometimes crash, and sometimes not, depending on whether sessions had been evicted or not. Make that situation always crash, so that it will be caught more easily in testing.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
yufengwangca
approved these changes
Mar 3, 2023
yunhanw-google
approved these changes
Mar 6, 2023
jmartinez-silabs
approved these changes
Mar 7, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…#25402) If GetSubjectDescriptor or GetAccessingFabricIndex were called on a CommandHandler after the command handling had gone async, it would sometimes crash, and sometimes not, depending on whether sessions had been evicted or not. Make that situation always crash, so that it will be caught more easily in testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If GetSubjectDescriptor or GetAccessingFabricIndex were called on a CommandHandler after the command handling had gone async, it would sometimes crash, and sometimes not, depending on whether sessions had been evicted or not.
Make that situation always crash, so that it will be caught more easily in testing.