[Telink] Block device role changing into Router if commissioning window opened and device not yet Router #25395

s07641069 · 2023-03-01T11:24:16Z

Problem

In case if commissioning window opened before FTD device becomes Router (still Child) you will see fails of pair or device will be not reachable after pairing with second controller.
Successful commissioning with second controller is possible only in case if commissioning window opened after device becomes Router or switching into Router starts after finish of second pairing.

Change overview

Block device role changing into Router if commissioning window opened and device not yet Router.

Testing

Tested manually.

Steps:

Pair FTD device with Apple Home (Apple HomePod Mini)
Open commissioning window before FTD device becomes Router
Pair device with Google Home (Google Nest Hub)
Device paired successfully and controllable
Device becomes Router after commissioning window closed (second device paired)

…ow opened and device not yet Router

src/app/server/CommissioningWindowManager.cpp

github-actions · 2023-03-01T12:05:33Z

PR #25395: Size comparison from eff5773 to 17571fe

Increases (1 build for cc32xx)

platform	target	config	section	`eff5773`	`17571fe`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_line	`2657207`	2657215	8	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`eff5773`	`17571fe`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	643465	643465	0
			(read/write)	203688	203688	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197088	197088	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930167	930167	0
			.debug_aranges	87336	87336	0
			.debug_frame	300024	300024	0
			.debug_info	20262893	20262893	0
			.debug_line	`2657207`	2657215	8
			.debug_loc	2799993	2799993	0
			.debug_ranges	282240	282240	0
			.debug_str	3023883	3023883	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105929	105929	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	378514	378514	0
			.symtab	256560	256560	0
			.text	535412	535412	0

- Add Thread stack lock during otThreadSetRouterEligible - Suppress Router promotion whenever any commissioning window is open

src/app/server/CommissioningWindowManager.cpp

github-actions · 2023-03-01T14:30:35Z

PR #25395: Size comparison from eff5773 to 3f77303

Increases (1 build for cc32xx)

platform	target	config	section	`eff5773`	`3f77303`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20262893	20262897	4	0.0
			.debug_line	`2657207`	2657212	5	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`eff5773`	`3f77303`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	643465	643465	0
			(read/write)	203688	203688	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197088	197088	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930167	930167	0
			.debug_aranges	87336	87336	0
			.debug_frame	300024	300024	0
			.debug_info	20262893	20262897	4
			.debug_line	`2657207`	2657212	5
			.debug_loc	2799993	2799993	0
			.debug_ranges	282240	282240	0
			.debug_str	3023883	3023883	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105929	105929	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	378514	378514	0
			.symtab	256560	256560	0
			.text	535412	535412	0

github-actions · 2023-03-01T14:49:56Z

PR #25395: Size comparison from eff5773 to 01991d3

Increases (1 build for cc32xx)

platform	target	config	section	`eff5773`	`01991d3`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20262893	`2026289`	5	0.0
			.debug_line	`2657207`	2657212	5	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`eff5773`	`01991d3`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	643465	643465	0
			(read/write)	203688	203688	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197088	197088	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930167	930167	0
			.debug_aranges	87336	87336	0
			.debug_frame	300024	300024	0
			.debug_info	20262893	`2026289`	5
			.debug_line	`2657207`	2657212	5
			.debug_loc	2799993	2799993	0
			.debug_ranges	282240	282240	0
			.debug_str	3023883	3023883	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105929	105929	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	378514	378514	0
			.symtab	256560	256560	0
			.text	535412	535412	0

src/app/server/CommissioningWindowManager.cpp

…ngWindow

…opened

github-actions · 2023-03-02T11:32:16Z

PR #25395: Size comparison from 1a1d0c3 to 332fd6a

Increases (1 build for cc32xx)

platform	target	config	section	`1a1d0c3`	`332fd6a`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20262923	20262927	4	0.0
			.debug_line	2657815	`2657820`	5	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`1a1d0c3`	`332fd6a`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	643465	643465	0
			(read/write)	203688	203688	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197088	197088	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930213	930213	0
			.debug_aranges	87336	87336	0
			.debug_frame	300024	300024	0
			.debug_info	20262923	20262927	4
			.debug_line	2657815	`2657820`	5
			.debug_loc	2800026	2800026	0
			.debug_ranges	282240	282240	0
			.debug_str	3023883	3023883	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105929	105929	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	378514	378514	0
			.symtab	256560	256560	0
			.text	535412	535412	0

s07641069 · 2023-03-02T14:06:20Z

@Damian-Nordic @bzbarsky-apple
Looks like PR ready for merge.
I did more testing after last changes and everything works fine.

…ow opened and device not yet Router (project-chip#25395) * [Telink] Block device role changing into Router if commissioning window opened and device not yet Router * [Telink] Add CHIP_DEVICE_CONFIG_ENABLE_THREAD check * [Telink] - Add API in ThreadStackManager - Add Thread stack lock during otThreadSetRouterEligible - Suppress Router promotion whenever any commissioning window is open * [Telink] Fix typo * [Telink] Move device role check into SetRouterPromotion * [Telink] Use _SetRouterPromotion only for FTD * [Telink] Move SetRouterPromotion(false) at the end of OpenCommissioningWindow

…ing window opened and device not yet Router (project-chip#25395)" This reverts commit c126158.

#28848) * Revert "[Telink] Move SetRouterPromotion(false) at the end of OpenCommissioningWindow (#25517)" This reverts commit 37c3db9. * Revert "[Telink] Block device role changing into Router if commissioning window opened and device not yet Router (#25395)" This reverts commit c126158.

project-chip#28848) * Revert "[Telink] Move SetRouterPromotion(false) at the end of OpenCommissioningWindow (project-chip#25517)" This reverts commit 37c3db9. * Revert "[Telink] Block device role changing into Router if commissioning window opened and device not yet Router (project-chip#25395)" This reverts commit c126158.

[Telink] Block device role changing into Router if commissioning wind…

dd0d82d

…ow opened and device not yet Router

github-actions bot added the app label Mar 1, 2023

Damian-Nordic reviewed Mar 1, 2023

View reviewed changes

src/app/server/CommissioningWindowManager.cpp Outdated Show resolved Hide resolved

[Telink] - Add API in ThreadStackManager

79fe9dc

- Add Thread stack lock during otThreadSetRouterEligible - Suppress Router promotion whenever any commissioning window is open

github-actions bot added the platform label Mar 1, 2023

[Telink] Fix typo

29055ab

Damian-Nordic reviewed Mar 1, 2023

View reviewed changes

src/app/server/CommissioningWindowManager.cpp Outdated Show resolved Hide resolved

[Telink] Move device role check into SetRouterPromotion

3f77303

[Telink] Use _SetRouterPromotion only for FTD

01991d3

Damian-Nordic approved these changes Mar 1, 2023

View reviewed changes

bzbarsky-apple approved these changes Mar 1, 2023

View reviewed changes

src/app/server/CommissioningWindowManager.cpp Show resolved Hide resolved

pullapprove bot added review - approved and removed review - pending labels Mar 1, 2023

[Telink] Move SetRouterPromotion(false) at the end of OpenCommissioni…

d32c5c9

…ngWindow

github-actions bot added linux tizen For Tizen platform labels Mar 2, 2023

Merge branch 'master' into block_device_role_changing_if_comm_window_…

332fd6a

…opened

andy31415 merged commit c126158 into project-chip:master Mar 2, 2023

s07641069 deleted the block_device_role_changing_if_comm_window_opened branch March 3, 2023 07:38

woody-apple added a commit to woody-apple/connectedhomeip that referenced this pull request Aug 22, 2023

Revert "[Telink] Block device role changing into Router if commission…

799becd

…ing window opened and device not yet Router (project-chip#25395)" This reverts commit c126158.

woody-apple added a commit to woody-apple/connectedhomeip that referenced this pull request Aug 23, 2023

Revert "[Telink] Block device role changing into Router if commission…

cbb03d4

…ing window opened and device not yet Router (project-chip#25395)" This reverts commit c126158.

woody-apple mentioned this pull request Aug 23, 2023

Revert "[Telink] Block device role changing into Router if commission… #28846

Closed

woody-apple added a commit to woody-apple/connectedhomeip that referenced this pull request Aug 23, 2023

Revert "[Telink] Block device role changing into Router if commission…

7c40f05

…ing window opened and device not yet Router (project-chip#25395)" This reverts commit c126158.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Telink] Block device role changing into Router if commissioning window opened and device not yet Router #25395

[Telink] Block device role changing into Router if commissioning window opened and device not yet Router #25395

s07641069 commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 2, 2023

s07641069 commented Mar 2, 2023 •

edited

Loading

[Telink] Block device role changing into Router if commissioning window opened and device not yet Router #25395

[Telink] Block device role changing into Router if commissioning window opened and device not yet Router #25395

Conversation

s07641069 commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 2, 2023

s07641069 commented Mar 2, 2023 • edited Loading

s07641069 commented Mar 2, 2023 •

edited

Loading