Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable -Wconversion for nrfconnect platform bits. #25383

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Enable -Wconversion for nrfconnect platform bits. #25383

merged 1 commit into from
Mar 1, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

No description provided.

@github-actions
Copy link

PR #25383: Size comparison from 20c65a2 to 95127e7

Decreases (1 build for cc32xx)
platform target config section 20c65a2 95127e7 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262893 20262892 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 20c65a2 95127e7 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930167 930167 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262893 20262892 -1 -0.0
.debug_line 2657205 2657205 0 0.0
.debug_loc 2799993 2799993 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the enable-Wconversion-nrf branch from 95127e7 to 33e595c Compare March 1, 2023 01:01
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

PR #25383: Size comparison from e75d35a to 33e595c

Increases (8 builds for bl602, bl702, k32w, qpg)
platform target config section e75d35a 33e595c change % change
bl602 lighting-app bl602 .text 1026858 1026860 2 0.0
bl702 lighting-app bl702 (read/write) 1189059 1189075 16 0.0
.debug_info 40600994 40601114 120 0.0
.debug_line 5279012 5279041 29 0.0
.debug_loc 3418178 3418278 100 0.0
.debug_ranges 372456 372480 24 0.0
.debug_str 3580500 3580726 226 0.0
.text 956138 956150 12 0.0
bl702+rpc (read/write) 1279039 1279055 16 0.0
.debug_info 45013026 45013146 120 0.0
.debug_line 5677774 5677803 29 0.0
.debug_loc 3614827 3614927 100 0.0
.debug_ranges 396232 396256 24 0.0
.debug_str 3984037 3984263 226 0.0
.text 1030910 1030922 12 0.0
k32w contact k32w0+release (read/write) 670480 670496 16 0.0
.text 571600 571616 16 0.0
light k32w0+release (read/write) 669532 669548 16 0.0
.text 570992 571008 16 0.0
lock k32w0+release (read/write) 626184 626200 16 0.0
.text 545948 545964 16 0.0
qpg lighting-app qpg6105+debug (read/write) 1151668 1151684 16 0.0
.text 598764 598780 16 0.0
lock-app qpg6105+debug (read/write) 1118876 1118892 16 0.0
.text 565976 565992 16 0.0
Decreases (1 build for cc32xx)
platform target config section e75d35a 33e595c change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262892 20262891 -1 -0.0
Full report (12 builds for bl602, bl702, cc32xx, k32w, linux, qpg)
platform target config section e75d35a 33e595c change % change
bl602 lighting-app bl602 (read/write) 1350806 1350806 0 0.0
.bss 94690 94690 0 0.0
.data 9744 9744 0 0.0
.text 1026858 1026860 2 0.0
bl602+rpc (read/write) 1396254 1396254 0 0.0
.bss 102738 102738 0 0.0
.data 10136 10136 0 0.0
.text 1057794 1057794 0 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1189059 1189075 16 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69785 69785 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4072 4072 0 0.0
.debug_abbrev 1551824 1551824 0 0.0
.debug_aranges 134304 134304 0 0.0
.debug_frame 492456 492456 0 0.0
.debug_info 40600994 40601114 120 0.0
.debug_line 5279012 5279041 29 0.0
.debug_loc 3418178 3418278 100 0.0
.debug_ranges 372456 372480 24 0.0
.debug_str 3580500 3580726 226 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107904 107904 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574866 574866 0 0.0
.symtab 173744 173744 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 956138 956150 12 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1279039 1279055 16 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77833 77833 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4616 4616 0 0.0
.debug_abbrev 1700019 1700019 0 0.0
.debug_aranges 142544 142544 0 0.0
.debug_frame 520144 520144 0 0.0
.debug_info 45013026 45013146 120 0.0
.debug_line 5677774 5677803 29 0.0
.debug_loc 3614827 3614927 100 0.0
.debug_ranges 396232 396256 24 0.0
.debug_str 3984037 3984263 226 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122016 122016 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635883 635883 0 0.0
.symtab 192080 192080 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1030910 1030922 12 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930167 930167 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262892 20262891 -1 -0.0
.debug_line 2657205 2657205 0 0.0
.debug_loc 2799993 2799993 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0
k32w contact k32w0+release (read/write) 670480 670496 16 0.0
.bss 77564 77564 0 0.0
.data 2204 2204 0 0.0
.text 571600 571616 16 0.0
light k32w0+release (read/write) 669532 669548 16 0.0
.bss 77236 77236 0 0.0
.data 2192 2192 0 0.0
.text 570992 571008 16 0.0
lock k32w0+release (read/write) 626184 626200 16 0.0
.bss 75372 75372 0 0.0
.data 2136 2136 0 0.0
.text 545948 545964 16 0.0
linux chip-tool-ipv6only arm64 (read only) 12131060 12131060 0 0.0
(read/write) 733448 733448 0 0.0
.bss 34296 34296 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 675552 675552 0 0.0
.dynamic 560 560 0 0.0
.got 15376 15376 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 587140 587140 0 0.0
.text 9803300 9803300 0 0.0
thermostat-no-ble arm64 (read only) 2517268 2517268 0 0.0
(read/write) 145208 145208 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77688 77688 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150704 150704 0 0.0
.text 2104256 2104256 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151668 1151684 16 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598764 598780 16 0.0
lock-app qpg6105+debug (read/write) 1118876 1118892 16 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565976 565992 16 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the enable-Wconversion-nrf branch from 33e595c to e06a123 Compare March 1, 2023 02:13
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

PR #25383: Size comparison from e75d35a to e06a123

Full report (2 builds for cc32xx, mbed)
platform target config section e75d35a e06a123 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930167 930167 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262892 20262892 0 0.0
.debug_line 2657205 2657205 0 0.0
.debug_loc 2799993 2799993 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467448 2467448 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430092 1430092 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the enable-Wconversion-nrf branch from e06a123 to bbb2cbd Compare March 1, 2023 03:38
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

PR #25383: Size comparison from eff5773 to bbb2cbd

Decreases (1 build for cc32xx)
platform target config section eff5773 bbb2cbd change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262893 20262892 -1 -0.0
Full report (1 build for cc32xx)
platform target config section eff5773 bbb2cbd change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930167 930167 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262893 20262892 -1 -0.0
.debug_line 2657207 2657207 0 0.0
.debug_loc 2799993 2799993 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the enable-Wconversion-nrf branch from bbb2cbd to e89b6fa Compare March 1, 2023 04:04
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

PR #25383: Size comparison from eff5773 to e89b6fa

Decreases (1 build for cc32xx)
platform target config section eff5773 e89b6fa change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262893 20262892 -1 -0.0
Full report (1 build for cc32xx)
platform target config section eff5773 e89b6fa change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930167 930167 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262893 20262892 -1 -0.0
.debug_line 2657207 2657207 0 0.0
.debug_loc 2799993 2799993 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

@bzbarsky-apple bzbarsky-apple enabled auto-merge (squash) March 1, 2023 14:41
@bzbarsky-apple bzbarsky-apple merged commit bb324cc into project-chip:master Mar 1, 2023
@bzbarsky-apple bzbarsky-apple deleted the enable-Wconversion-nrf branch March 1, 2023 16:26
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Enable -Wconversion for nrfconnect platform bits. (project-chip#25383)
1e37544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliffamzn cliffamzn cliffamzn approved these changes

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@emargolis emargolis emargolis approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
nrf connect platform review - approved zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @emargolis @Damian-Nordic @jmeg-sfy @cliffamzn