Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing TV-app layout in landscape mode #25209

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

cliffamzn
Copy link
Contributor

The on/off button is hidden in landscape mode if there isn't a scrollview. Adding it here so that it is usable. Also making some minor fixes in some other areas of the layouts to make it a bit nicer.

The on/off button is hidden in landscape mode if there isn't a
scrollview. Adding it here so that it is usable. Also making some minor
fixes in some other areas of the layouts to make it a bit nicer.
@github-actions
Copy link

PR #25209: Size comparison from e64736c to d22cd2c

Decreases (1 build for nrfconnect)
platform target config section e64736c d22cd2c change % change
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1110108 1110092 -16 -0.0
text 775988 775984 -4 -0.0
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
platform target config section e64736c d22cd2c change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642545 642545 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930168 930168 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299752 299752 0 0.0
.debug_info 20254060 20254060 0 0.0
.debug_line 2655143 2655143 0 0.0
.debug_loc 2795383 2795383 0 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3017470 3017470 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377598 377598 0 0.0
.symtab 256144 256144 0 0.0
.text 534604 534604 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466784 2466784 0 0.0
.bss 215780 215780 0 0.0
.data 5880 5880 0 0.0
.text 1429428 1429428 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164856 1164856 0 0.0
bss 143411 143411 0 0.0
rodata 134852 134852 0 0.0
text 806744 806744 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1110108 1110092 -16 -0.0
bss 142567 142567 0 0.0
rodata 111816 111816 0 0.0
text 775988 775984 -4 -0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1370260 1370260 0 0.0
bss 105874 105874 0 0.0
rodata 212288 212288 0 0.0
text 766580 766580 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151348 1151348 0 0.0
.bss 99796 99796 0 0.0
.data 852 852 0 0.0
.text 598444 598444 0 0.0
lock-app qpg6105+debug (read/write) 1118356 1118356 0 0.0
.bss 96284 96284 0 0.0
.data 864 864 0 0.0
.text 565456 565456 0 0.0

@andy31415 andy31415 merged commit 7cb57a0 into project-chip:master Feb 22, 2023
@cliffamzn cliffamzn deleted the tv-server-layout branch February 23, 2023 19:35
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
The on/off button is hidden in landscape mode if there isn't a
scrollview. Adding it here so that it is usable. Also making some minor
fixes in some other areas of the layouts to make it a bit nicer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants