-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly terminate linux example apps (followup from #24979) #25053
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:AllClustersAppDoNotCloseAnymoreOnCtrlC
Feb 14, 2023
Merged
Properly terminate linux example apps (followup from #24979) #25053
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:AllClustersAppDoNotCloseAnymoreOnCtrlC
Feb 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
ksperling-apple and
lazarkov
February 14, 2023 14:16
pullapprove
bot
requested review from
pjzander-signify,
saurabhst and
selissia
February 14, 2023 14:16
pullapprove
bot
requested review from
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21 and
yufengwangca
February 14, 2023 14:16
vivien-apple
force-pushed
the
AllClustersAppDoNotCloseAnymoreOnCtrlC
branch
from
February 14, 2023 14:17
a7f6f59
to
87fe0ca
Compare
PR #25053: Size comparison from b4b51b2 to 87fe0ca Full report (1 build for cc32xx)
|
vivien-apple
force-pushed
the
AllClustersAppDoNotCloseAnymoreOnCtrlC
branch
from
February 14, 2023 14:32
87fe0ca
to
ddb2947
Compare
andy31415
approved these changes
Feb 14, 2023
arkq
reviewed
Feb 14, 2023
andy31415
reviewed
Feb 14, 2023
PR #25053: Size comparison from 62d9187 to ddb2947 Increases (1 build for cc32xx)
Full report (3 builds for cc32xx, qpg)
|
vivien-apple
force-pushed
the
AllClustersAppDoNotCloseAnymoreOnCtrlC
branch
from
February 14, 2023 15:07
ddb2947
to
bfc4661
Compare
vivien-apple
force-pushed
the
AllClustersAppDoNotCloseAnymoreOnCtrlC
branch
from
February 14, 2023 15:10
bfc4661
to
7728c09
Compare
arkq
approved these changes
Feb 14, 2023
bzbarsky-apple
approved these changes
Feb 14, 2023
msandstedt
approved these changes
Feb 14, 2023
woody-apple
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#24979 has broken the ability for the
all-clusters-app
to properly terminates on Ctrl^C (in fact it does not terminates at all now.)