Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly terminate linux example apps (followup from #24979) #25053

Conversation

vivien-apple
Copy link
Contributor

Problem

#24979 has broken the ability for the all-clusters-app to properly terminates on Ctrl^C (in fact it does not terminates at all now.)

@github-actions
Copy link

PR #25053: Size comparison from b4b51b2 to 87fe0ca

Full report (1 build for cc32xx)
platform target config section b4b51b2 87fe0ca change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640361 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20180781 20180781 0 0.0
.debug_line 2649926 2649926 0 0.0
.debug_loc 2786017 2786017 0 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3005287 3005287 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532604 0 0.0

@vivien-apple vivien-apple force-pushed the AllClustersAppDoNotCloseAnymoreOnCtrlC branch from 87fe0ca to ddb2947 Compare February 14, 2023 14:32
@github-actions
Copy link

PR #25053: Size comparison from 62d9187 to ddb2947

Increases (1 build for cc32xx)
platform target config section 62d9187 ddb2947 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20180782 20180783 1 0.0
Full report (3 builds for cc32xx, qpg)
platform target config section 62d9187 ddb2947 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640361 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20180782 20180783 1 0.0
.debug_line 2649926 2649926 0 0.0
.debug_loc 2786017 2786017 0 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3005287 3005287 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532604 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149152 1149152 0 0.0
.bss 99900 99900 0 0.0
.data 848 848 0 0.0
.text 596252 596252 0 0.0
lock-app qpg6105+debug (read/write) 1116896 1116896 0 0.0
.bss 96396 96396 0 0.0
.data 860 860 0 0.0
.text 563992 563992 0 0.0

@vivien-apple vivien-apple force-pushed the AllClustersAppDoNotCloseAnymoreOnCtrlC branch from ddb2947 to bfc4661 Compare February 14, 2023 15:07
@vivien-apple vivien-apple force-pushed the AllClustersAppDoNotCloseAnymoreOnCtrlC branch from bfc4661 to 7728c09 Compare February 14, 2023 15:10
@vivien-apple vivien-apple enabled auto-merge (squash) February 14, 2023 16:53
@vivien-apple vivien-apple merged commit 59a4de4 into project-chip:master Feb 14, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants