Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we're not using non-type-safe attribute reads. #25029

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Make sure we're not using non-type-safe attribute reads. #25029

merged 1 commit into from
Feb 14, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Gets rid of the emberAfReadServerAttribute define, and adds a lint to restrict emberAfReadAttribute use to the implementation of the type-safe reads.

@github-actions
Copy link

PR #25029: Size comparison from e7528bc to d3e91e8

Increases (1 build for cc32xx)
platform target config section e7528bc d3e91e8 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20180782 2018078 1 0.0
Decreases (1 build for cc32xx)
platform target config section e7528bc d3e91e8 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_line 2649926 2649921 -5 -0.0
Full report (1 build for cc32xx)
platform target config section e7528bc d3e91e8 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640361 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20180782 2018078 1 0.0
.debug_line 2649926 2649921 -5 -0.0
.debug_loc 2786017 2786017 0 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3005287 3005287 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532604 0 0.0

@bzbarsky-apple
Make sure we're not using non-type-safe attribute reads.
cc97463 
Gets rid of the emberAfReadServerAttribute define, and adds a lint to restrict
emberAfReadAttribute use to the implementation of the type-safe reads.
@bzbarsky-apple bzbarsky-apple force-pushed the type-safe-attribute-reads branch from d3e91e8 to cc97463 Compare February 14, 2023 14:39
@github-actions
Copy link

PR #25029: Size comparison from 62d9187 to cc97463

Decreases (1 build for cc32xx)
platform target config section 62d9187 cc97463 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_line 2649926 2649921 -5 -0.0
Full report (1 build for cc32xx)
platform target config section 62d9187 cc97463 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640361 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20180782 20180782 0 0.0
.debug_line 2649926 2649921 -5 -0.0
.debug_loc 2786017 2786017 0 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3005287 3005287 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532604 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 7161326 into project-chip:master Feb 14, 2023
@bzbarsky-apple bzbarsky-apple deleted the type-safe-attribute-reads branch February 14, 2023 16:46
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Make sure we're not using non-type-safe attribute reads. (project-chi…
4a20d10 
…p#25029)

Gets rid of the emberAfReadServerAttribute define, and adds a lint to restrict
emberAfReadAttribute use to the implementation of the type-safe reads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@arkq arkq Awaiting requested review from arkq

@msandstedt msandstedt Awaiting requested review from msandstedt

@andy31415 andy31415 Awaiting requested review from andy31415

Assignees
No one assigned
Labels
app examples github review - approved workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @andy31415 @msandstedt @arkq