-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Lighting App ZAP Files with Supported Events #25025
Merged
emargolis
merged 3 commits into
project-chip:master
from
emargolis:emargolis/feature/fix-lighting-app-zap-events
Feb 15, 2023
Merged
Updated Lighting App ZAP Files with Supported Events #25025
emargolis
merged 3 commits into
project-chip:master
from
emargolis:emargolis/feature/fix-lighting-app-zap-events
Feb 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
February 13, 2023 20:10
pullapprove
bot
requested review from
xylophone21,
yufengwangca and
yunhanw-google
February 13, 2023 20:10
PR #25025: Size comparison from 831fd05 to fd5e0fd Increases (1 build for qpg)
Full report (3 builds for cc32xx, qpg)
|
bzbarsky-apple
approved these changes
Feb 13, 2023
woody-apple
approved these changes
Feb 14, 2023
Fixed Test Script ZAP file: - Removed SoftwareFault event from the Software Diagnostics Cluster, which is not implemented for this app. - Removed all Thread Network Diagnostics Cluster events, which are currently not implemented in the SDK at all. Added Supported Events to the Lighting App ZAP Example File
emargolis
force-pushed
the
emargolis/feature/fix-lighting-app-zap-events
branch
from
February 14, 2023 17:50
fd5e0fd
to
7976d46
Compare
auto-merge was automatically disabled
February 14, 2023 18:25
Merge queue setting changed
yufengwangca
approved these changes
Feb 14, 2023
PR #25025: Size comparison from bd78b86 to 7976d46 Increases (11 builds for bl602, bl702, cyw30739, psoc6, qpg, telink)
Decreases (4 builds for bl602, psoc6)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, linux, psoc6, qpg, telink)
|
PR #25025: Size comparison from 6c1cb33 to 587c5db Increases (16 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, psoc6, qpg, telink)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, cc32xx, psoc6, qpg, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
) * Updated Lighting App ZAP Files with Supported Events Fixed Test Script ZAP file: - Removed SoftwareFault event from the Software Diagnostics Cluster, which is not implemented for this app. - Removed all Thread Network Diagnostics Cluster events, which are currently not implemented in the SDK at all. Added Supported Events to the Lighting App ZAP Example File * ZAP REGEN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Test Script ZAP file:
not implemented for this app.
not implemented in the SDK at all.
Added Supported Events to the Lighting App ZAP Example File