Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event list information in .matter files #24991

Merged
merged 7 commits into from
Feb 14, 2023

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Feb 11, 2023

Report what events are expected to be generated by each cluster in matter files.

Reviewer notes:

  • I compared windowapp endpoint_config contents to validate actual output
  • it seems to me that only a subset of zap files have event list defined (I don't see light switch or pump examples or such). Assuming this is ok and expected.
  • Our golden image tests do not currently use events as no python codegen depends on it. If we add those, we probably want that as a followup.
> rg --files-without-match --glob '*.matter' 'emits event' examples
examples/light-switch-app/light-switch-common/light-switch-app.matter
examples/dynamic-bridge-app/bridge-common/bridge-app.matter
examples/log-source-app/log-source-common/log-source-app.matter
examples/contact-sensor-app/contact-sensor-common/contact-sensor-app.matter
examples/placeholder/linux/apps/app2/config.matter
examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter
examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter
.....
examples/chef/devices/rootnode_doorlock_aNKYAreMXE.matter
examples/placeholder/linux/apps/app1/config.matter
examples/ota-provider-app/ota-provider-common/ota-provider-app.matter
examples/thermostat/thermostat-common/thermostat.matter
examples/ota-requestor-app/ota-requestor-common/ota-requestor-app.matter
examples/tv-app/tv-common/tv-app.matter
examples/tv-casting-app/tv-casting-common/tv-casting-app.matter
examples/temperature-measurement-app/esp32/main/temperature-measurement.matter
examples/pump-app/pump-common/pump-app.matter
examples/pump-controller-app/pump-controller-common/pump-controller-app.matter
examples/lighting-app/silabs/efr32/data_model/lighting-wifi-app.matter
examples/lighting-app/silabs/efr32/data_model/lighting-thread-app.matter
examples/lighting-app/lighting-common/lighting-app.matter

@github-actions
Copy link

PR #24991: Size comparison from 4895dc6 to 55d9849

Full report (6 builds for cc32xx, nrfconnect, qpg)
platform target config section 4895dc6 55d9849 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194444 20194444 0 0.0
.debug_line 2649825 2649825 0 0.0
.debug_loc 2785969 2785969 0 0.0
.debug_ranges 280696 280696 0 0.0
.debug_str 3001474 3001474 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1162380 1162380 0 0.0
bss 143531 143531 0 0.0
rodata 134376 134376 0 0.0
text 804576 804576 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1108392 1108392 0 0.0
bss 142687 142687 0 0.0
rodata 111364 111364 0 0.0
text 774568 774568 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1367600 1367600 0 0.0
bss 105990 105990 0 0.0
rodata 211808 211808 0 0.0
text 764280 764280 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148688 1148688 0 0.0
.bss 99876 99876 0 0.0
.data 848 848 0 0.0
.text 595788 595788 0 0.0
lock-app qpg6105+debug (read/write) 1116736 1116736 0 0.0
.bss 96396 96396 0 0.0
.data 860 860 0 0.0
.text 563832 563832 0 0.0

@github-actions
Copy link

PR #24991: Size comparison from 3d9bc88 to fa6d90e

Increases (1 build for cc32xx)
platform target config section 3d9bc88 fa6d90e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20180782 20180783 1 0.0
Full report (3 builds for cc32xx, qpg)
platform target config section 3d9bc88 fa6d90e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640361 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20180782 20180783 1 0.0
.debug_line 2649926 2649926 0 0.0
.debug_loc 2786017 2786017 0 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3005287 3005287 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532604 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149152 1149152 0 0.0
.bss 99900 99900 0 0.0
.data 848 848 0 0.0
.text 596252 596252 0 0.0
lock-app qpg6105+debug (read/write) 1116896 1116896 0 0.0
.bss 96396 96396 0 0.0
.data 860 860 0 0.0
.text 563992 563992 0 0.0

@arkq
Copy link
Contributor

arkq commented Feb 14, 2023

Dummy bootstrap force version

Maybe bumping version in https://github.com/project-chip/connectedhomeip/blob/master/scripts/py_matter_idl/setup.cfg#L17 will help with the bootstrap cache issue. The cache itself will not be invalidated, but newer package should be installed. The best way would be to install this package in a developer mode - in such a case only symlink will be cached.

@andy31415 andy31415 merged commit d5ae3f7 into project-chip:master Feb 14, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
* Update matter idl to report emmited events

* Parsing support for emitted clusters

* Restyle

* zap regen all

* zap regen all

* Dummy bootstrap force version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants