Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AttributeWritePermission from types-silabs.xml and makes it a … #24926

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Remove AttributeWritePermission from types-silabs.xml and makes it a … #24926

merged 1 commit into from
Feb 9, 2023

Conversation

vivien-apple
Copy link
Contributor

…not generated enum

Problem

This PR remove AttributeWritePermission from the list of generated enums and makes it a non generated enum class instead.

@vivien-apple vivien-apple self-assigned this Feb 8, 2023
@github-actions github-actions bot added the app label Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24926: Size comparison from fd3217a to 7b6d617

Increases (1 build for cc32xx)
platform target config section fd3217a 7b6d617 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_line 2649781 2649797 16 0.0
.debug_loc 2785870 2785922 52 0.0
Decreases (1 build for cc32xx)
platform target config section fd3217a 7b6d617 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194648 20194396 -252 -0.0
.debug_str 3001804 3001474 -330 -0.0
Full report (1 build for cc32xx)
platform target config section fd3217a 7b6d617 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194648 20194396 -252 -0.0
.debug_line 2649781 2649797 16 0.0
.debug_loc 2785870 2785922 52 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001804 3001474 -330 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@vivien-apple vivien-apple force-pushed the RemoveAttributeWritePermission branch from 7b6d617 to b9d70af Compare February 9, 2023 08:26
@vivien-apple vivien-apple enabled auto-merge (squash) February 9, 2023 08:27
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

PR #24926: Size comparison from cc0f0d8 to b9d70af

Increases (1 build for cc32xx)
platform target config section cc0f0d8 b9d70af change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_line 2649781 2649797 16 0.0
.debug_loc 2785870 2785922 52 0.0
Decreases (1 build for cc32xx)
platform target config section cc0f0d8 b9d70af change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194647 20194395 -252 -0.0
.debug_str 3001804 3001474 -330 -0.0
Full report (1 build for cc32xx)
platform target config section cc0f0d8 b9d70af change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194647 20194395 -252 -0.0
.debug_line 2649781 2649797 16 0.0
.debug_loc 2785870 2785922 52 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001804 3001474 -330 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@vivien-apple vivien-apple merged commit 19f7965 into project-chip:master Feb 9, 2023
lpbeliveau-silabs pushed a commit to lpbeliveau-silabs/connectedhomeip that referenced this pull request Feb 13, 2023
@vivien-apple @lpbeliveau-silabs
Remove AttributeWritePermission from types-silabs.xml and makes it a …
29afa03 
…not generated enum (project-chip#24926)
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@vivien-apple
Remove AttributeWritePermission from types-silabs.xml and makes it a …
116cb71 
…not generated enum (project-chip#24926)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @andy31415 @bzbarsky-apple