Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add darwin-framework-tool to Xcode project #24921

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Add darwin-framework-tool to Xcode project #24921

merged 1 commit into from
Feb 17, 2023

Conversation

krypton36
Copy link
Contributor

Summary:
This adds the ability to build darwin-framework-tool with existing files in Xcode. Matter.framework is in an Xcode project and is built using xcodebuild. We need to link to Matter.framework, so this will make is much easier. This also gives the ability to compile via UI and xcodebuild.

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24921: Size comparison from c49ee00 to 158e047

Increases (1 build for cc32xx)
platform target config section c49ee00 158e047 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20141926 20141928 2 0.0
Full report (1 build for cc32xx)
platform target config section c49ee00 158e047 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640249 640249 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20141926 20141928 2 0.0
.debug_line 2649806 2649806 0 0.0
.debug_loc 2785917 2785917 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 2979174 2979174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105601 105601 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@krypton36 krypton36 force-pushed the AddDarwinFWToolToXcode branch from 158e047 to aeec6a6 Compare February 8, 2023 16:43
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24921: Size comparison from c49ee00 to aeec6a6

Increases (1 build for cc32xx)
platform target config section c49ee00 aeec6a6 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20141926 20141927 1 0.0
Full report (1 build for cc32xx)
platform target config section c49ee00 aeec6a6 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640249 640249 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20141926 20141927 1 0.0
.debug_line 2649806 2649806 0 0.0
.debug_loc 2785917 2785917 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 2979174 2979174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105601 105601 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@krypton36 krypton36 force-pushed the AddDarwinFWToolToXcode branch from aeec6a6 to b7e55ae Compare February 8, 2023 17:20
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24921: Size comparison from c49ee00 to b7e55ae

Increases (1 build for cc32xx)
platform target config section c49ee00 b7e55ae change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20141926 20141927 1 0.0
Full report (1 build for cc32xx)
platform target config section c49ee00 b7e55ae change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640249 640249 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20141926 20141927 1 0.0
.debug_line 2649806 2649806 0 0.0
.debug_loc 2785917 2785917 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 2979174 2979174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105601 105601 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@krypton36 krypton36 force-pushed the AddDarwinFWToolToXcode branch from b7e55ae to 61723ce Compare February 8, 2023 18:12
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24921: Size comparison from c49ee00 to 61723ce

Full report (4 builds for cc32xx, mbed, qpg)
platform target config section c49ee00 61723ce change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640249 640249 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20141926 20141926 0 0.0
.debug_line 2649806 2649806 0 0.0
.debug_loc 2785917 2785917 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 2979174 2979174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105601 105601 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464592 2464592 0 0.0
.bss 215892 215892 0 0.0
.data 5880 5880 0 0.0
.text 1427236 1427236 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148688 1148688 0 0.0
.bss 99876 99876 0 0.0
.data 848 848 0 0.0
.text 595788 595788 0 0.0
lock-app qpg6105+debug (read/write) 1116752 1116752 0 0.0
.bss 96396 96396 0 0.0
.data 860 860 0 0.0
.text 563848 563848 0 0.0

@krypton36 krypton36 force-pushed the AddDarwinFWToolToXcode branch 2 times, most recently from 5bfdf9a to 80cb874 Compare February 9, 2023 16:33
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

PR #24921: Size comparison from 16a64b3 to 80cb874

Increases (1 build for cc32xx)
platform target config section 16a64b3 80cb874 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194395 20194396 1 0.0
Full report (1 build for cc32xx)
platform target config section 16a64b3 80cb874 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194395 20194396 1 0.0
.debug_line 2649797 2649797 0 0.0
.debug_loc 2785922 2785922 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001474 3001474 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@pullapprove pullapprove bot requested a review from kkasperczyk-no February 14, 2023 20:17
@woody-apple woody-apple force-pushed the AddDarwinFWToolToXcode branch from 80cb874 to d5b1731 Compare February 14, 2023 20:17
@krypton36 krypton36 force-pushed the AddDarwinFWToolToXcode branch from d5b1731 to 3aed50b Compare February 17, 2023 20:01
@bzbarsky-apple
Copy link
Contributor

Fast-tracking platform-specific change with platform owner review.

@bzbarsky-apple bzbarsky-apple enabled auto-merge (squash) February 17, 2023 20:04
@github-actions
Copy link

PR #24921: Size comparison from e35345c to 3aed50b

Decreases (2 builds for cc32xx, qpg)
platform target config section e35345c 3aed50b change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20361460 20361459 -1 -0.0
qpg lighting-app qpg6105+debug (read/write) 1150652 1150644 -8 -0.0
.text 597748 597740 -8 -0.0
Full report (3 builds for cc32xx, qpg)
platform target config section e35345c 3aed50b change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642217 642217 0 0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934242 0 0.0
.debug_aranges 87472 87472 0 0.0
.debug_frame 300288 300288 0 0.0
.debug_info 20361460 20361459 -1 -0.0
.debug_line 2661258 2661258 0 0.0
.debug_loc 2797585 2797585 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3020435 3020435 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534392 534392 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150652 1150644 -8 -0.0
.bss 99820 99820 0 0.0
.data 852 852 0 0.0
.text 597748 597740 -8 -0.0
lock-app qpg6105+debug (read/write) 1118204 1118204 0 0.0
.bss 96316 96316 0 0.0
.data 864 864 0 0.0
.text 565304 565304 0 0.0

@krypton36 krypton36 mentioned this pull request Feb 17, 2023
Closed
@bzbarsky-apple bzbarsky-apple merged commit 01b88b4 into project-chip:master Feb 17, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@krypton36
Add darwin-framework-tool to xcode (project-chip#24921)
703f291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksperling-apple ksperling-apple ksperling-apple left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@woody-apple woody-apple woody-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krypton36 @bzbarsky-apple @woody-apple @ksperling-apple