-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CIPD zap to mac-arm64 #24762
Merged
Merged
Add CIPD zap to mac-arm64 #24762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same binary as the mac-amd64 one, but should work thanks to Rosetta.
PR #24762: Size comparison from f951fa9 to 5dd904d Increases (7 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for bl702, cc13x2_26x2, esp32, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 1, 2023
The mac-arm64 version is now in CIPD (https://chrome-infra-packages.appspot.com/p/fuchsia/third_party/zap/mac-arm64/+/ABHTOz1w1HhcQSd7TegJP8AQ7yWu1m7O_MmSiQSOGFAC), so this should be good to go. |
PR #24762: Size comparison from b12dbc3 to 74dc24d Increases (8 builds for bl602, cc13x2_26x2, esp32, telink)
Decreases (6 builds for cc13x2_26x2, esp32, nrfconnect, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Feb 3, 2023
pullapprove
bot
requested review from
amitnj,
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
lazarkov,
lpbeliveau-silabs,
LuDuda and
msandstedt
February 3, 2023 18:49
pullapprove
bot
requested review from
pjzander-signify,
saurabhst,
selissia,
tecimovic,
vijs and
xylophone21
February 3, 2023 18:49
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Add CIPD zap to mac-arm64 This is the same binary as the mac-amd64 one, but should work thanks to Rosetta. * Run restyler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same binary as the mac-amd64 one, but should work thanks to Rosetta.
Note that the binary is not available in CIPD yet: we'll need to wait for https://fuchsia-review.googlesource.com/c/infra/3pp/+/794888 to be merged, and for the CIPD updater to run (which may happen up to 4 hours later).