Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align naming in Application Launcher cluster XML with the spec. #24594

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Align naming in Application Launcher cluster XML with the spec. #24594

merged 4 commits into from
Jan 24, 2023
+691 −523

Conversation

bzbarsky-apple
Copy link
Contributor

REVIEW NOTE: Only the first commit contains manual changes. The rest is code-generated.

@bzbarsky-apple bzbarsky-apple force-pushed the rename-application-launcher branch from 8c54a2b to 307ea13 Compare January 23, 2023 20:28
@bzbarsky-apple bzbarsky-apple linked an issue Jan 23, 2023 that may be closed by this pull request
Various Application Launcher command handlers return garbage data #24596
Closed
@bzbarsky-apple bzbarsky-apple force-pushed the rename-application-launcher branch from 11e095c to b47d01d Compare January 23, 2023 23:00
@github-actions
Copy link

PR #24594: Size comparison from 4589809 to b47d01d

Increases (15 builds for bl702, cc13x2_26x2, cyw30739, linux, nrfconnect, psoc6, qpg, telink)
platform target config section 4589809 b47d01d change % change
bl702 lighting-app bl702 .debug_aranges 134064 134080 16 0.0
.debug_frame 491056 491108 52 0.0
.debug_info 40196308 40197392 1084 0.0
.debug_line 5266802 5266868 66 0.0
.debug_loc 3402340 3402493 153 0.0
.debug_ranges 371936 371952 16 0.0
.debug_str 3533047 3535926 2879 0.1
bl702+rpc .debug_aranges 142288 142304 16 0.0
.debug_frame 518760 518812 52 0.0
.debug_info 44592645 44593730 1085 0.0
.debug_line 5665127 5665193 66 0.0
.debug_loc 3598465 3598687 222 0.0
.debug_ranges 395640 395656 16 0.0
.debug_str 3936356 3939235 2879 0.1
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 640711 640847 136 0.0
.text 562964 563100 136 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585394 585402 8 0.0
.app_xip_area 461412 461420 8 0.0
linux chip-tool-ipv6only arm64 (read only) 10958732 10961500 2768 0.0
.rodata 568540 568732 192 0.0
.text 8740612 8743188 2576 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1110548 1110692 144 0.0
text 773796 773940 144 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_aranges 111264 111280 16 0.0
.debug_frame 373660 373716 56 0.0
.debug_info 27470494 27473456 2962 0.0
.debug_line 3766816 3767340 524 0.0
.debug_loc 3651585 3652502 917 0.0
.debug_ranges 357264 357424 160 0.0
.debug_str 3482273 3485170 2897 0.1
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1691228 1691372 144 0.0
.debug_aranges 110528 110544 16 0.0
.debug_frame 376104 376160 56 0.0
.debug_info 27026372 27031065 4693 0.0
.debug_line 3774972 3775626 654 0.0
.debug_loc 3634986 3636231 1245 0.0
.debug_ranges 355232 355392 160 0.0
.debug_str 3467062 3470979 3917 0.1
.strtab 536118 536281 163 0.0
.symtab 408400 408432 32 0.0
.text 1491248 1491392 144 0.0
light cy8ckit_062s2_43012 .debug_aranges 102808 102824 16 0.0
.debug_frame 346664 346720 56 0.0
.debug_info 22489142 22490392 1250 0.0
.debug_line 3339690 3339769 79 0.0
.debug_loc 3336752 3337009 257 0.0
.debug_ranges 319448 319464 16 0.0
.debug_str 3272731 3275610 2879 0.1
lock cy8ckit_062s2_43012 .debug_aranges 103192 103208 16 0.0
.debug_frame 348464 348520 56 0.0
.debug_info 22709759 22711006 1247 0.0
.debug_line 3341459 3341542 83 0.0
.debug_loc 3358296 3358628 332 0.0
.debug_ranges 321304 321320 16 0.0
.debug_str 3289138 3292017 2879 0.1
qpg lock-app qpg6105+debug (read/write) 1115984 1115992 8 0.0
.text 563080 563088 8 0.0
telink all-clusters-minimal-app tlsr9518adk80d (read/write) 964788 964972 184 0.0
text 652104 652282 178 0.0
light-switch-app tlsr9518adk80d text 597174 597176 2 0.0
ota-requestor-app tlsr9518adk80d text 608286 608288 2 0.0
thermostat tlsr9518adk80d text 597936 597940 4 0.0
Decreases (5 builds for bl602, bl702, esp32, telink)
platform target config section 4589809 b47d01d change % change
bl602 lighting-app bl602 (read/write) 1345490 1345482 -8 -0.0
.text 1022522 1022518 -4 -0.0
bl602+rpc .text 1053454 1053452 -2 -0.0
bl702 lighting-app bl702 (read/write) 1184951 1184935 -16 -0.0
.text 952354 952352 -2 -0.0
esp32 all-clusters-app m5stack (read only) 1093671 1093659 -12 -0.0
.flash.text 1088287 1088275 -12 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1026616 1026608 -8 -0.0
text 688800 688796 -4 -0.0
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 4589809 b47d01d change % change
bl602 lighting-app bl602 (read/write) 1345490 1345482 -8 -0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022522 1022518 -4 -0.0
bl602+rpc (read/write) 1390930 1390930 0 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053454 1053452 -2 -0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1184951 1184935 -16 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70701 70701 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549734 1549734 0 0.0
.debug_aranges 134064 134080 16 0.0
.debug_frame 491056 491108 52 0.0
.debug_info 40196308 40197392 1084 0.0
.debug_line 5266802 5266868 66 0.0
.debug_loc 3402340 3402493 153 0.0
.debug_ranges 371936 371952 16 0.0
.debug_str 3533047 3535926 2879 0.1
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106704 106704 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571662 571662 0 0.0
.symtab 173168 173168 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 952354 952352 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1277579 1277579 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78749 78749 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698172 1698172 0 0.0
.debug_aranges 142288 142304 16 0.0
.debug_frame 518760 518812 52 0.0
.debug_info 44592645 44593730 1085 0.0
.debug_line 5665127 5665193 66 0.0
.debug_loc 3598465 3598687 222 0.0
.debug_ranges 395640 395656 16 0.0
.debug_str 3936356 3939235 2879 0.1
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121232 121232 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632259 632259 0 0.0
.symtab 191520 191520 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1029340 1029340 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677223 677223 0 0.0
(read/write) 174632 174632 0 0.0
.bss 81548 81548 0 0.0
.data 3384 3384 0 0.0
.rodata 87471 87471 0 0.0
.text 589440 589440 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640711 640847 136 0.0
(read/write) 158240 158240 0 0.0
.bss 80740 80740 0 0.0
.data 3384 3384 0 0.0
.rodata 77423 77423 0 0.0
.text 562964 563100 136 0.0
lock-ftd LP_CC2652R7 (read only) 674347 674347 0 0.0
(read/write) 174980 174980 0 0.0
.bss 79108 79108 0 0.0
.data 3312 3312 0 0.0
.rodata 76267 76267 0 0.0
.text 597600 597600 0 0.0
lock-mtd LP_CC2652R7 (read only) 660663 660663 0 0.0
(read/write) 183928 183928 0 0.0
.bss 74372 74372 0 0.0
.data 3312 3312 0 0.0
.rodata 102735 102735 0 0.0
.text 557448 557448 0 0.0
pump-app LP_CC2652R7 (read only) 687379 687379 0 0.0
(read/write) 162676 162676 0 0.0
.bss 79068 79068 0 0.0
.data 3276 3276 0 0.0
.rodata 90395 90395 0 0.0
.text 596504 596504 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672811 672811 0 0.0
(read/write) 177356 177356 0 0.0
.bss 79180 79180 0 0.0
.data 3300 3300 0 0.0
.rodata 86475 86475 0 0.0
.text 585856 585856 0 0.0
shell LP_CC2652R7 (read only) 668494 668494 0 0.0
(read/write) 185432 185432 0 0.0
.bss 83620 83620 0 0.0
.data 3380 3380 0 0.0
.rodata 84206 84206 0 0.0
.text 583972 583972 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585394 585402 8 0.0
.app_xip_area 461412 461420 8 0.0
.bss 66432 66432 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589118 589118 0 0.0
.app_xip_area 459840 459840 0 0.0
.bss 71720 71720 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550766 550766 0 0.0
.app_xip_area 432272 432272 0 0.0
.bss 60984 60984 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974240 974240 0 0.0
.bss 147144 147144 0 0.0
.data 2196 2196 0 0.0
.text 824880 824880 0 0.0
BRD4161A+rs911x (read/write) 1037308 1037308 0 0.0
.bss 181632 181632 0 0.0
.data 2040 2040 0 0.0
.text 853616 853616 0 0.0
lock-app BRD4161A+wf200 (read/write) 1064932 1064932 0 0.0
.bss 153152 153152 0 0.0
.data 2048 2048 0 0.0
.text 909712 909712 0 0.0
lighting-app BRD4187C (read/write) 1151392 1151392 0 0.0
.bss 133644 133644 0 0.0
.data 2544 2544 0 0.0
.text 990608 990608 0 0.0
window-app BRD4187C (read/write) 1144108 1144108 0 0.0
.bss 135060 135060 0 0.0
.data 2568 2568 0 0.0
.text 981884 981884 0 0.0
esp32 all-clusters-app c3devkit (read only) 1041436 1041436 0 0.0
(read/write) 1515802 1515802 0 0.0
.dram0.bss 75904 75904 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 219888 219888 0 0.0
.flash.text 1041436 1041436 0 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1093671 1093659 -12 -0.0
(read/write) 497475 497475 0 0.0
.dram0.bss 80952 80952 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 248680 248680 0 0.0
.flash.text 1088287 1088275 -12 -0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 660908 660908 0 0.0
.bss 77360 77360 0 0.0
.data 2112 2112 0 0.0
.text 562324 562324 0 0.0
light k32w0+release (read/write) 672820 672820 0 0.0
.bss 75144 75144 0 0.0
.data 2064 2064 0 0.0
.text 592884 592884 0 0.0
lock k32w0+release (read/write) 632288 632288 0 0.0
.bss 75912 75912 0 0.0
.data 2084 2084 0 0.0
.text 551564 551564 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10958732 10961500 2768 0.0
(read/write) 696696 696696 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 640120 640120 0 0.0
.dynamic 560 560 0 0.0
.got 14120 14120 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 568540 568732 192 0.0
.text 8740612 8743188 2576 0.0
thermostat-no-ble arm64 (read only) 2503556 2503556 0 0.0
(read/write) 144648 144648 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150816 150816 0 0.0
.text 2090944 2090944 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463192 2463192 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425836 1425836 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164968 1164968 0 0.0
bss 147118 147118 0 0.0
rodata 133232 133232 0 0.0
text 804400 804400 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1110548 1110692 144 0.0
bss 146274 146274 0 0.0
rodata 110380 110380 0 0.0
text 773796 773940 144 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366544 1366544 0 0.0
bss 106418 106418 0 0.0
rodata 210720 210720 0 0.0
text 763568 763568 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840944 840944 0 0.0
(read/write) 1749972 1749972 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189736 189736 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1251027 1251027 0 0.0
.debug_aranges 111264 111280 16 0.0
.debug_frame 373660 373716 56 0.0
.debug_info 27470494 27473456 2962 0.0
.debug_line 3766816 3767340 524 0.0
.debug_loc 3651585 3652502 917 0.0
.debug_ranges 357264 357424 160 0.0
.debug_str 3482273 3485170 2897 0.1
.heap 840944 840944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 575773 575773 0 0.0
.symtab 423440 423440 0 0.0
.text 1549184 1549184 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841752 841752 0 0.0
(read/write) 1691228 1691372 144 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188928 188928 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1236738 1236738 0 0.0
.debug_aranges 110528 110544 16 0.0
.debug_frame 376104 376160 56 0.0
.debug_info 27026372 27031065 4693 0.0
.debug_line 3774972 3775626 654 0.0
.debug_loc 3634986 3636231 1245 0.0
.debug_ranges 355232 355392 160 0.0
.debug_str 3467062 3470979 3917 0.1
.heap 841752 841752 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536118 536281 163 0.0
.symtab 408400 408432 32 0.0
.text 1491248 1491392 144 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849944 849944 0 0.0
(read/write) 1611148 1611148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071778 1071778 0 0.0
.debug_aranges 102808 102824 16 0.0
.debug_frame 346664 346720 56 0.0
.debug_info 22489142 22490392 1250 0.0
.debug_line 3339690 3339769 79 0.0
.debug_loc 3336752 3337009 257 0.0
.debug_ranges 319448 319464 16 0.0
.debug_str 3272731 3275610 2879 0.1
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474042 474042 0 0.0
.symtab 377600 377600 0 0.0
.text 1419360 1419360 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 844960 844960 0 0.0
(read/write) 1645212 1645212 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073126 1073126 0 0.0
.debug_aranges 103192 103208 16 0.0
.debug_frame 348464 348520 56 0.0
.debug_info 22709759 22711006 1247 0.0
.debug_line 3341459 3341542 83 0.0
.debug_loc 3358296 3358628 332 0.0
.debug_ranges 321304 321320 16 0.0
.debug_str 3289138 3292017 2879 0.1
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476977 476977 0 0.0
.symtab 379424 379424 0 0.0
.text 1448440 1448440 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148304 1148304 0 0.0
.bss 100668 100668 0 0.0
.data 848 848 0 0.0
.text 595404 595404 0 0.0
lock-app qpg6105+debug (read/write) 1115984 1115992 8 0.0
.bss 97188 97188 0 0.0
.data 860 860 0 0.0
.text 563080 563088 8 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1026616 1026608 -8 -0.0
bss 98552 98552 0 0.0
text 688800 688796 -4 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964788 964972 184 0.0
bss 97696 97696 0 0.0
text 652104 652282 178 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 869236 869236 0 0.0
bss 89844 89844 0 0.0
text 582572 582572 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 885700 885700 0 0.0
bss 89940 89940 0 0.0
text 597174 597176 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964044 964044 0 0.0
bss 97996 97996 0 0.0
text 663178 663178 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 899532 899532 0 0.0
bss 90888 90888 0 0.0
text 608286 608288 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 888916 888916 0 0.0
bss 91328 91328 0 0.0
text 597936 597940 4 0.0

@bzbarsky-apple bzbarsky-apple merged commit 8f4dcee into project-chip:master Jan 24, 2023
@bzbarsky-apple bzbarsky-apple deleted the rename-application-launcher branch January 24, 2023 03:29
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Align naming in Application Launcher cluster XML with the spec. (proj…
659444b 
…ect-chip#24594)

* Align naming in Application Launcher cluster XML with the spec.

Also fixes some command fields that should have been optional to actually be optional.

* Auto-update ZAP files.

* Regenerate generated code.

* Fix another build issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@lazarkov lazarkov lazarkov approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Various Application Launcher command handlers return garbage data
3 participants
@bzbarsky-apple @lazarkov @msandstedt