-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS TvCasting app: Adding async completion callback to startMatterServer API #24285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdecenzo
approved these changes
Jan 5, 2023
PR #24285: Size comparison from 3012b18 to 63ccd5f Increases (2 builds for bl602, telink)
Decreases (3 builds for bl702, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
requested review from
a team,
xylophone21,
andy31415,
msandstedt,
mrjerryjohns,
LuDuda,
lazarkov,
hawk248,
woody-apple and
bzbarsky-apple
January 6, 2023 02:04
hawk248
approved these changes
Jan 6, 2023
sharadb-amazon
force-pushed
the
fix-20230105
branch
from
January 6, 2023 20:58
63ccd5f
to
2d6ba1f
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex and
harsha-rajendran
January 6, 2023 20:58
pullapprove
bot
requested review from
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lpbeliveau-silabs,
mlepage-google,
mspang,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vivien-apple and
yufengwangca
January 6, 2023 20:58
PR #24285: Size comparison from 89df4ac to 2d6ba1f Increases (11 builds for bl602, bl702, psoc6, qpg, telink)
Decreases (3 builds for esp32, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cletnick
pushed a commit
to cletnick/connectedhomeip
that referenced
this pull request
Jan 10, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #24048
Change summary
The startMatterServer API did not have a callback to tell the client application when it was fully done/complete. This change adds that callback.
Testing
Tested with the iOS tv-casting-app and the Linux tv-app to check that the callback is made after the startMatterServer API is done initing the server and reconnecting to the video players previously connected to (if any)