-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Implements initial version of the Client Monitoring Cluster #24284
[ICD] Implements initial version of the Client Monitoring Cluster #24284
Conversation
src/app/clusters/client-monitoring-server/client-monitoring-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/client-monitoring-server/client-monitoring-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/client-monitoring-server/client-monitoring-server.h
Outdated
Show resolved
Hide resolved
PR #24284: Size comparison from 260307b to 9c5a86b Increases above 0.2%:
Increases (2 builds for bl702)
Decreases (1 build for bl602)
Full report (10 builds for bl602, bl702, k32w, mbed, qpg)
|
PR #24284: Size comparison from 260307b to 4cb2120 Increases above 0.2%:
Increases (19 builds for bl702, cc13x2_26x2, linux, nrfconnect, psoc6, telink)
Decreases (3 builds for cc13x2_26x2, psoc6)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…oject-chip#24284) * Initial implementation of the CM cluster * Update function calls * Add Yaml tests for cluster * remove unwanted changes * generated files * Address review comments * restyler * zap regen error * add cm table source file to cmake build * fix android build * add CM to descriptor cluster test * fix esp build * fix CI nit * fix typo
|
||
/** | ||
* @brief Client Monitoring Cluster RegisterClientMonitoring Command callback (from client) | ||
* | ||
*/ | ||
bool emberAfClientMonitoringClusterRegisterClientMonitoringCallback( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is RegisterClientMonitoring? I don't see it in the spec...
|
||
CHIP_ERROR ClientMonitoringAttributeAccess::Write(const ConcreteDataAttributePath & aPath, AttributeValueDecoder & aDecoder) | ||
{ | ||
return CHIP_IM_GLOBAL_STATUS(UnsupportedWrite); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? Per spec this should work, no?
* @brief Client Monitoring Cluster UregisterClientMonitoring Command callback (from client) | ||
* | ||
*/ | ||
bool emberAfClientMonitoringClusterUnregisterClientMonitoringCallback( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this in the spec either.
@@ -44,7 +44,14 @@ limitations under the License. | |||
<access op="invoke" privilege="manage"/> | |||
</command> | |||
|
|||
<command source="client" code="0x01" name="StayAwakeRequest" optional="true"> | |||
<command source="client" code="0x01" name="UnregisterClientMonitoring" optional="false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this coming from?
…oject-chip#24284) * Initial implementation of the CM cluster * Update function calls * Add Yaml tests for cluster * remove unwanted changes * generated files * Address review comments * restyler * zap regen error * add cm table source file to cmake build * fix android build * add CM to descriptor cluster test * fix esp build * fix CI nit * fix typo
Description
Testing