-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for a subscription trying to send reports on a defunct session. #24113
Merged
woody-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:add-subscription-defunct-session-test
Dec 16, 2022
Merged
Add a test for a subscription trying to send reports on a defunct session. #24113
woody-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:add-subscription-defunct-session-test
Dec 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex and
harsha-rajendran
December 16, 2022 18:29
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
tcarmelveilleux,
selissia,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
December 16, 2022 18:29
woody-apple
approved these changes
Dec 16, 2022
yunhanw-google
approved these changes
Dec 16, 2022
PR #24113: Size comparison from 245a7f4 to dd79e92 Increases (4 builds for bl602, cc13x2_26x2, telink)
Decreases (8 builds for bl702, cc13x2_26x2, psoc6, qpg, telink)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…sion. This is testing the situation described in project-chip#24093
bzbarsky-apple
force-pushed
the
add-subscription-defunct-session-test
branch
from
December 16, 2022 21:08
dd79e92
to
ced0c02
Compare
PR #24113: Size comparison from b01695e to ced0c02 Increases (9 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Decreases (7 builds for bl602, cc13x2_26x2, k32w, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is testing the situation described in
#24093
Fixes #24104