-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mNumReportsInFlight check test when failing to send report #24106
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/issue_24104
Dec 16, 2022
Merged
add mNumReportsInFlight check test when failing to send report #24106
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/issue_24104
Dec 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
force-pushed
the
feature/issue_24104
branch
from
December 16, 2022 08:45
e3d3b1c
to
d9fe83e
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
December 16, 2022 08:45
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
December 16, 2022 08:45
PR #24106: Size comparison from 23f0824 to d9fe83e Increases (3 builds for bl602, cc13x2_26x2, telink)
Decreases (13 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 16, 2022
yunhanw-google
force-pushed
the
feature/issue_24104
branch
from
December 16, 2022 17:44
d9fe83e
to
59858f6
Compare
PR #24106: Size comparison from 245a7f4 to 59858f6 Increases (2 builds for cc13x2_26x2, esp32)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24104
We need to test the mNumReportsInFlight when sendReport is failing and read handler state does not move to AwaitingReportResponse, without PR 24093, this new test would fail since defunct would not decrement mNumReportsInFlight when it is not in AwaitingReportResponse state , with PR 24093, this test would succeed.
This PR also add new test facility in NetworkTestHelper which can inject the sendError after particular number of allowed message.