-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[silabs] wi-fi provisioning for efr32 in build command #24036
Merged
woody-apple
merged 2 commits into
project-chip:master
from
Thirsrin:feature/wifi_provisioning_for_efr32_in_build_command
Dec 15, 2022
Merged
[silabs] wi-fi provisioning for efr32 in build command #24036
woody-apple
merged 2 commits into
project-chip:master
from
Thirsrin:feature/wifi_provisioning_for_efr32_in_build_command
Dec 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24036: Size comparison from 71da650 to f79faaa Increases (13 builds for bl602, bl702, cc13x2_26x2, esp32, k32w, psoc6, telink)
Decreases (8 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Dec 12, 2022
andy31415
reviewed
Dec 12, 2022
andy31415
reviewed
Dec 12, 2022
andy31415
reviewed
Dec 12, 2022
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jtung-apple,
ksperling-apple,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
December 13, 2022 09:08
pullapprove
bot
requested review from
woody-apple,
xylophone21,
jelderton,
vijs,
jtung-apple,
vivien-apple,
ksperling-apple,
lazarkov,
LuDuda,
msandstedt and
saurabhst
December 14, 2022 16:31
woody-apple
approved these changes
Dec 14, 2022
woody-apple
force-pushed
the
feature/wifi_provisioning_for_efr32_in_build_command
branch
from
December 14, 2022 18:22
47e24f5
to
3833b75
Compare
PR #24036: Size comparison from 5b3c08a to 3833b75 Increases (7 builds for esp32, psoc6, telink)
Decreases (5 builds for cyw30739, nrfconnect, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Thirsrin
force-pushed
the
feature/wifi_provisioning_for_efr32_in_build_command
branch
from
December 15, 2022 05:35
3833b75
to
e44bdd1
Compare
PR #24036: Size comparison from 9292923 to e44bdd1 Increases (10 builds for bl602, bl702, cc13x2_26x2, esp32, telink)
Decreases (5 builds for cc13x2_26x2, esp32, psoc6)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24036: Size comparison from 7fbf6da to eac11aa Increases (6 builds for bl602, cc13x2_26x2, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being Added?
Fix to provide the Wi-Fi credentials (ssid, psk) in build command.
Testing:
MG12/MG24+RS9116(lighting, lock, light-switch, window, thermostat)
MG12/MG24+WF200 (lighting, lock, light-switch, window, thermostat)
MG12/MG24+RS9116(lighting, lock, light-switch, window, thermostat)
MG12/MG24+WF200 (lighting, lock, light-switch, window, thermostat)