-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add support for hex:/str: prefixed OCTET_STRING for compl… #23967
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_HexStrPrefixForOctetStringArgumentForComplex
Dec 14, 2022
Merged
[chip-tool] Add support for hex:/str: prefixed OCTET_STRING for compl… #23967
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_HexStrPrefixForOctetStringArgumentForComplex
Dec 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns and
msandstedt
December 8, 2022 09:14
pullapprove
bot
requested review from
tehampson,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
December 8, 2022 09:14
PR #23967: Size comparison from 6ccbb7c to d0e8975 Increases (11 builds for bl602, cc13x2_26x2, esp32, linux, psoc6, qpg, telink)
Decreases (6 builds for bl702, cc13x2_26x2, linux, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Dec 8, 2022
bzbarsky-apple
approved these changes
Dec 9, 2022
vivien-apple
force-pushed
the
ChipTool_HexStrPrefixForOctetStringArgumentForComplex
branch
from
December 13, 2022 16:22
d0e8975
to
9659ec5
Compare
vivien-apple
requested review from
andy31415
and removed request for
isiu-apple
December 13, 2022 16:23
PR #23967: Size comparison from 3f6e635 to 9659ec5 Increases (6 builds for bl702, linux, psoc6, telink)
Decreases (4 builds for bl602, cyw30739, psoc6)
Full report (46 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
ChipTool_HexStrPrefixForOctetStringArgumentForComplex
branch
from
December 14, 2022 09:10
9659ec5
to
04a7de3
Compare
PR #23967: Size comparison from 8055d86 to 04a7de3 Increases (8 builds for bl702, cc13x2_26x2, cyw30739, esp32, linux, psoc6, telink)
Decreases (6 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Dec 14, 2022
…ex arguments instead of always assuming this is an hex string For compatibility reason the default behavior of assuming this is an hex string is preserved.
vivien-apple
force-pushed
the
ChipTool_HexStrPrefixForOctetStringArgumentForComplex
branch
from
December 14, 2022 14:49
04a7de3
to
8c4a1c5
Compare
PR #23967: Size comparison from 8a9ac9b to 8c4a1c5 Increases (9 builds for cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, esp32, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ex arguments instead of always assuming this is an hex string
For compatibility reason the default behavior of assuming this is an hex string is preserved.
Problem
chip-tool
parsesOCTET_STRING
argument using thehex:
prefix, but for "complex" argument that needs to be passed as a json value, passinghex:
result into an error.Furthermore, there is also a way to pass normal string for regular argument using the
str:
prefix but it is not allowed for "complex" argument too.