-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install zap v2022.11.16 in Docker images. #23643
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing from a zip file since deb installation seems to add an entire XWindows dependency and based on feedback from zap folks the zip file is the one more tested.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk and
saurabhst
November 16, 2022 19:54
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 16, 2022 19:54
PR #23643: Size comparison from bbf3111 to 0527581 Increases (1 build for bl702)
Decreases (2 builds for bl602, bl702)
Full report (12 builds for bl602, bl702, k32w, mbed, nrfconnect, qpg)
|
…th missing node.js installation from the base image
bzbarsky-apple
approved these changes
Nov 16, 2022
PR #23643: Size comparison from bbf3111 to eb34ceb Increases (4 builds for psoc6, telink)
Decreases (4 builds for bl602, esp32, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Nov 17, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* Install zap v2022.11.16 in Docker images. Installing from a zip file since deb installation seems to add an entire XWindows dependency and based on feedback from zap folks the zip file is the one more tested. * Fix moved line * Only keep zap-cli in the image. zap is a UI tool, not used and quite large * Remove node install: zap should be a stand-alone tool * Remove chip-build-zap because this image is not compatible anymore with missing node.js installation from the base image * Remove chip-build-zap from chip-build-vscode * Remove zap image build attempts from CI
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* Install zap v2022.11.16 in Docker images. Installing from a zip file since deb installation seems to add an entire XWindows dependency and based on feedback from zap folks the zip file is the one more tested. * Fix moved line * Only keep zap-cli in the image. zap is a UI tool, not used and quite large * Remove node install: zap should be a stand-alone tool * Remove chip-build-zap because this image is not compatible anymore with missing node.js installation from the base image * Remove chip-build-zap from chip-build-vscode * Remove zap image build attempts from CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing from a zip file since deb installation seems to add an entire XWindows dependency and based on feedback from zap folks the zip file is the one more tested.
Changes:
This is to prepare for:
To follow up (future PRs):